feat: use a custom network for docker databases #55
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main advantage of running the containers in a user defined network is that they have access to the name resolution service provided by docker. This allows containers to refer to each other by container name instead of IP, this is particularly useful when running external container that wants to connect to the DBs (e.g. running a MySQL client in a separate container).
Ian2012
approved these changes
Nov 1, 2024
|
Is this ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main advantage of running the containers in a user defined network is that they have access to the name resolution service provided by docker. This allows containers to refer to each other by container name instead of IP, this is particularly useful when running external container that wants to connect to the DBs (e.g. running a MySQL client in a separate container).