Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add support for lispville #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JJPandari
Copy link

This is still a work in progress.

I love lispyville, and would like to add support for it in evil-goggles.

The current code change should be working as I tested, but two commands are not added because they don't satisfy evil-goggle's convention of taking BEG END as arguments:

  (lispyville->                    :face evil-goggles-shift-face                 :switch evil-goggles-enable-shift                 :advice evil-goggles--generic-async-advice)
  (lispyville-<                    :face evil-goggles-shift-face                 :switch evil-goggles-enable-shift                 :advice evil-goggles--generic-async-advice)

@noctuid Do you use evil-goggles? what do you think?

OH and those :switchs obviously need more refining before this PR can be merged.

@noctuid
Copy link

noctuid commented Oct 24, 2019

I'm not using it at the moment, but let me know if there's anything I can do in lispyville to make integration easier.

@JJPandari
Copy link
Author

two commands are not added because they don't satisfy evil-goggle's convention of taking BEG END as arguments:

Just found there's no way to make lispyville-< and lispyville-> work without changing lispy's code, because functions like lispy--barf-backward actually barf by moving the ), while to me the user, it's the barfed sexp being moved and should be goggled.


For the :switchs I'm not sure if we should reuse existing ones or make new ones, waiting for response from the maintainers...

@wbolster
Copy link
Contributor

i considered adding support for lispyville as well, but it turns out someone beat me to it! even better! 👍

@edkolev is there anything we can do to help moving this forward?

wbolster added a commit to wbolster/dotfiles that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants