Build lottie by passing -DLOTTIE_MODULE=OFF

fixes #92
ed-asriyan · May 26, 2024 · 778ba49 · 778ba49
1 parent 327c653
commit 778ba49
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/build-darwin.yml b/.github/workflows/build-darwin.yml
@@ -42,7 +42,7 @@ jobs:
         run: cmake --preset conan-release
 
       - name: Build the app
-        run: cmake -DCMAKE_BUILD_TYPE=Release CMakeLists.txt && cmake --build . --config Release
+        run: cmake -DCMAKE_BUILD_TYPE=Release -DLOTTIE_MODULE=OFF CMakeLists.txt && cmake --build . --config Release
 
       - name: Upload executable as artifact
         uses: actions/upload-artifact@v3

diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
@@ -37,7 +37,7 @@ jobs:
         run: cmake --preset conan-default
 
       - name: Build the app
-        run: cmake -DCMAKE_BUILD_TYPE=Release CMakeLists.txt && cmake --build . --config Release
+        run: cmake -DCMAKE_BUILD_TYPE=Release -DLOTTIE_MODULE=OFF CMakeLists.txt && cmake --build . --config Release
 
       - name: Upload executable as artifact
         uses: actions/upload-artifact@v3

diff --git a/Dockerfile b/Dockerfile
@@ -14,7 +14,7 @@ RUN conan install . --build=missing -s build_type=Release
 
 COPY CMakeLists.txt .
 COPY src src
-RUN cmake -DCMAKE_BUILD_TYPE=Release CMakeLists.txt && cmake --build . --config Release
+RUN cmake -DCMAKE_BUILD_TYPE=Release -DLOTTIE_MODULE=OFF CMakeLists.txt && cmake --build . --config Release
 
 FROM debian:buster-slim as lottie-to-gif
 COPY --from=builder-gifski /usr/local/cargo/bin/gifski /usr/bin/gifski

diff --git a/README.md b/README.md
@@ -106,7 +106,7 @@ Results will be saved next to each source file in the same directory.
         ```
 3. Build
    ```commandline
-   cmake -DCMAKE_BUILD_TYPE=Release CMakeLists.txt && cmake --build . --config Release
+   cmake -DCMAKE_BUILD_TYPE=Release -DLOTTIE_MODULE=OFF CMakeLists.txt && cmake --build . --config Release
    ```
 4. Convert!
    - To convert to GIF:

diff --git a/test-files/2.json b/test-files/2.json
diff --git a/test-files/index.json.txt b/test-files/index.json.txt
@@ -4,5 +4,8 @@
   },
   "1.json": {
     "link": "https://lottiefiles.com/18168-stay-safe-stay-home"
+  },
+  "2.json": {
+    "link": "https://github.com/ed-asriyan/lottie-converter/issues/92"
   }
 }