Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PathItems to Components #620

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add PathItems to Components #620

merged 1 commit into from
Jun 5, 2024

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented May 24, 2024 •
edited
Loading

Support having named PathItem entries under Components.

  • update model interfaces
  • update ModelConstructionTest
  • update OASModelReader and static file tests
    • add a Path Item under /components
    • reference the Path Item from a Path Item under /paths which has additional operations

For #437

@Azquelt Azquelt mentioned this pull request May 24, 2024
Merged
@Azquelt Azquelt requested a review from MikeEdgar May 24, 2024 16:59
MikeEdgar
MikeEdgar approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tck/src/main/java/org/eclipse/microprofile/openapi/reader/MyOASModelReaderImpl.java Outdated Show resolved Hide resolved
@Azquelt Azquelt force-pushed the pathitems-in-components branch from 5b17715 to 56c93af Compare June 5, 2024 11:09
@Azquelt
Copy link
Member Author

Azquelt commented Jun 5, 2024

Rebased on main to resolve conflicts.

@Azquelt
Add PathItems to Components
350d6c1 
- update model interfaces
- update ModelConstructionTest
- update OASModelReader and static file tests
@Azquelt Azquelt force-pushed the pathitems-in-components branch from 56c93af to 350d6c1 Compare June 5, 2024 11:12
@MikeEdgar MikeEdgar merged commit 0d63cfe into eclipse:main Jun 5, 2024
4 checks passed
@Azquelt Azquelt deleted the pathitems-in-components branch June 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azquelt @MikeEdgar