Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codicon color and URI support to TerminalOptions #13413

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dhuebner
Copy link
Contributor

This is a copy of the original PR #12861
First commit was cherry picked from FernandoAscencio@ba3dda2
In the second commit, I applied the suggested changed from the original PR.

The original description below

What it does

Closes #12074

This commit adds URI and { light, dark } support for terminal icons.
This commit adds ColorTheme support for ThemeIcons
Support for ExtensionTerminalOptions#iconPath

How to test

Open Theia
Install from VSIX the test extension
Check the result follow VSCode test results seen below:

Review checklist

Reminder for reviewers

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of initial high-level comments.

packages/terminal/src/browser/base/terminal-widget.ts Outdated Show resolved Hide resolved
packages/plugin-ext/src/plugin/terminal-ext.ts Outdated Show resolved Hide resolved
packages/terminal/src/browser/terminal-widget-impl.ts Outdated Show resolved Hide resolved
@JonasHelming JonasHelming removed the request for review from rschnekenbu March 22, 2024 07:46
@dhuebner
Copy link
Contributor Author

@tsmaeder
Thanks for your re-view, I will have a look today.

@tsmaeder
Copy link
Contributor

@dhuebner the license check fails. Do we need an ip ticket here?

@dhuebner
Copy link
Contributor Author

@tsmaeder
It hard to say for me what exactly fails from reading the error log.
The original PR, however, didn't fail #12861
And I added no additional dependencies.

@rschnekenbu
Copy link
Contributor

@dhuebner, there was a message yesterday from Thomas on Theia dev list about those IP checks failing. You may rebase on top of master, that should fix the issue. #13524 is the PR fixing the issue.

@msujew
Copy link
Member

msujew commented May 27, 2024

@dhuebner @tsmaeder I've updated the PR myself. I've added support for custom icons for quick pick items and quick pick buttons. You can find an example plugin for that here. Simply use the Quick Input Samples command. Use the multiStepInput option to test that the button icons work as expected. With that I was able to align the icon code of terminals and quick picks.

FernandoAscencio and others added 6 commits June 4, 2024 13:32
Partial close of 12074

- This commit adds URI and { light, dark } support for terminal icons.
- This commit adds ColorTheme support for ThemeIcons
- Support for `ExtensionTerminalOptions#iconPath`

Signed-Off-By: FernandoAscencio <[email protected]>
(cherry picked from commit ba3dda2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

vscode: Missing partial icon and color API support for ExtensionTerminalOptions and TerminalOptions
5 participants