Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override user-defined THEIA_CONFIG_DIR #13708

Merged
merged 1 commit into from May 15, 2024

Conversation

xai
Copy link
Contributor

@xai xai commented May 13, 2024

What it does

The current behavior of Theia is to ignore a user-defined THEIA_CONFIG_DIR environment variable, which is an unexpected regression from a user's point of view.

This patch ensures that a user-defined value has precedence over the BackendApplicationPath/data/user-data location and the default location ~/.theia.

Fixes #13700

Contributed on behalf of STMicroelectronics

How to test

  1. Set the THEIA_CONFIG_DIR environment variable to a non-default value:
    export THEIA_CONFIG_DIR=~/theia-test-data-dir
  2. Start Theia (e.g., yarn browser start)
  3. Confirm that you see a line similar to the following in stdout, indicating that the value you provided in step 1 is used as configuration directory:
Configuration directory URI: 'file:///home/xai/theia-test-data-dir'
  1. Confirm that this directory has been created on your filesystem (if it has not already existed before)

Follow-ups

Review checklist

Reminder for reviewers

Fixes eclipse-theia#13700

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew merged commit da32fed into eclipse-theia:master May 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Failed to customize the data folder
2 participants