-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to customize the data folder #13700
Comments
@xai FYI |
fanyipin
changed the title
Failed to customize the directory folder
Failed to customize the data folder
May 8, 2024
xai
added a commit
to eclipsesource/theia
that referenced
this issue
May 13, 2024
Fixes eclipse-theia#13700 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
@JonasHelming, please assign this issue to me (cannot self-assign). Thanks! |
1 task
Thank you very much @fanyipin for raising this issue! My understanding here is the same, so I opened PR #13708, which ensures the 1. property, that is currently violated. |
msujew
pushed a commit
that referenced
this issue
May 15, 2024
Fixes #13700 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description:
Prior to version 1.44, the ConfigDirUri variable could be customized via process.env.THEIA_CONFIG_DIR. This meant users could set process.env.THEIA_CONFIG_DIR within their application to specify a custom data directory. However, after the introduction of the logic in the app directory in version 1.44, process.env.THEIA_CONFIG_DIR is being re-assigned, which seems to override previous settings. I understand that there should be a priority order where:
Here is the logical code for handling ConfigDirUri, which I understand should not be specified directly if process.env.THEIA_CONFIG_DIR has a value
Steps to Reproduce:
if process.env.THEIA_CONFIG_DIR is specified as a directory, the latest cache file address is not matched
Additional Information
The text was updated successfully, but these errors were encountered: