Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#935 Adjusted computation of horizontal toolbar size to account for inner control #936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mh2207yatta
Copy link

Fixes #935

Copy link
Contributor

Test Results

     299 files  ±0       299 suites  ±0   5m 39s ⏱️ -3s
  4 096 tests ±0    4 088 ✔️ ±0    8 💤 ±0  0 ±0 
12 200 runs  ±0  12 127 ✔️ ±0  73 💤 ±0  0 ±0 

Results for commit 904574c. ± Comparison against base commit 27feab2.

@HeikoKlare
Copy link
Contributor

I addition to my validation of this PR that I have posted in the according issue #935, I have one further finding:

Each view can have its own toolbar. This toolbar is placed (right aligned) in the same row as the view tab headers in case there is sufficient space. Otherwise, the toolbar is placed below the tab headers.
However, with this change, the toolbar will always be placed below the tab header.

This is how it looked before:
image

And this is how it looks now:
image

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last comment, rendering is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox in Toolbar cut off
3 participants