Fix upside-down image in macOS Sonoma

[sratz]

Image flipping was originally implemented back in 2008 [1,2]. Possibly as a workaround.

It appears something has changed with macOS Sonoma (14.0), and this is no longer necessary.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=254797
[2] ca92157

Resolves #772.

[github-actions]

Test Results

     299 files  ±0       299 suites  ±0   6m 3s ⏱️ +39s
  4 095 tests ±0    4 087 ✔️ ±0    8 💤 ±0  0 ❌ ±0 
12 197 runs  ±0  12 124 ✔️ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit 1572b37. ± Comparison against base commit 030807a.

[Phillipus]

Hi I tested this with the Snippets. It only fixes the case where a GC is used:

#772 (comment) and #772 (comment)

These are still upside down:

#772 (comment) and #772 (comment)

[Phillipus]

@sratz I found a clue here:

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/Image.java

Lines 1011 to 1014 in 030807a

	ImageData.blit(
	imageData.data, imageData.depth, imageData.bytesPerLine, imageData.getByteOrder(), imageData.width, imageData.height, palette.redMask, palette.greenMask, palette.blueMask,
	buffer, 32, bpr, ImageData.MSB_FIRST, imageData.width, imageData.height, 0xFF0000, 0xFF00, 0xFF,
	false, false);

by changing the last parameter flipY to true the image is correct.

[Phillipus]

@sratz I found a clue here:

Please ignore last comment. In testing in a real world app this causes a regression and images are upside-down elsewhere.