Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant configuration and add architecture to fragment name #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Feb 6, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results

   297 files   -     2    297 suites   - 2   25m 17s ⏱️ + 18m 37s
 4 066 tests  -    34    123 ✅  - 3 969   3 💤  -  5  1 ❌ +1   3 939 🔥 + 3 939 
19 654 runs  +7 442  4 286 ✅  - 7 851  13 💤  - 62  2 ❌ +2  15 353 🔥 +15 353 

For more details on these failures and errors, see this check.

Results for commit a3551d0. ± Comparison against base commit 8dc46be.

This pull request removes 34 tests.
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testTextTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testUrlTransfer
…

♻️ This comment has been updated with latest results.

Add Eclipse-PlatformFilter to the platform-specific tests in order to
make the global environment configuration obsolete.
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laeubi I unified the fragment names to have the arch mentioned in the same way for all platforms, even though there is only one fragment for Windows, but AFAIK aarch64 for Windows might be a thing in the future.

I also added corresponding Eclipse-PlatformFilter to all platform specific tests hoping that this will fix the test failures.

@HannesWell
Copy link
Member

@laeubi could you please refactor out the name improvements into a separate PR? These changes are probably fine, but the configuration changes seem to need more work.

@HannesWell
Copy link
Member

@laeubi could you please refactor out the name improvements into a separate PR? These changes are probably fine, but the configuration changes seem to need more work.

@laeubi I have now extracted the name unification into #1159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants