[Build] Make staging of relevant files robust against file absence #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage the relevant kind of files in isolation and don't fail if that kind of file does not exist at all in the repository. Otherwise the entire step fails if the repo for example doesn't contain a feature.xml, because the previous 'git add' command then fails with: fatal: pathspec '*/feature.xml' did not match any files
|
Tested with eclipse-jdt/eclipse.jdt.debug#516 and it worked as expected. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage the relevant kind of files in isolation and don't fail if that kind of file does not exist at all in the repository.
Otherwise the entire step fails if the repo for example doesn't contain a feature.xml, because the previous 'git add' command then fails with:
fatal: pathspec '*/feature.xml' did not match any filesThis became relevant for example in eclipse-jdt/eclipse.jdt.debug#516
Follow-up on #2352.