[Builds] Remove elements unnecessary with the new version-bump workflow #2387
Conversation
With the new reusable workflow for automated version increments in pull-requests it is not necessary anymore to bump versions in advance during release preparation or the enable bumping if the property 'compare-version-with-baselines.skip' is set to false. Everything now happens automatically and these elements can therefore be removed.
HannesWell
force-pushed
the
remove-unnecessary-build-elements
branch
from
c45aafc
to
e8d34a8
Compare
|
As thenew workflow is not yet setup on this repo, this one can not be pushed, right? |
This repository is not really the problem since the removed elements are (hardly) used here, but we should await until it's active in all other (active) SDK repositories. And while JDT should only be a matter of committer time, Equinox and SWT seem to need more adjustments and might take longer. |
| @@ -774,32 +774,6 @@ | |||
| </repository> | |||
| </repositories> | |||
| </profile> | |||
| <profile> | |||
| <!-- This provile enables automatic version bumps when running the build --> | |||
There was a problem hiding this comment.
As mentioned last time this can be used locally as well, so I would prefer to keep the profile
There was a problem hiding this comment.
Yes it can be used. But I wonder if it is really used by a relevant number of people?
Personally I have never used it and didn't even know about before working in this area. Do you use it or know anybody that uses it?
Now that we have it automated at GH, I think this particular profile became even less relevant.
With the new reusable workflow for automated version increments in pull-requests, introduced with #2352, it is not necessary anymore to bump versions in advance during release preparation or the enable bumping if the property 'compare-version-with-baselines.skip' is set to false. Everything now happens automatically and these elements can therefore be removed.
Removing these elements avoids partly duplicated configuration and generally reduced the amount of configuration.