Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest NLS translations, updates exelib #19512

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pshipton
Copy link
Member

No description provided.

@@ -944,4 +944,16 @@ J9NLS_EXELIB_INTERNAL_HELP_XXNOPORTABLESHAREDCACHE.system_action=
J9NLS_EXELIB_INTERNAL_HELP_XXNOPORTABLESHAREDCACHE.user_response=
# END NON-TRANSLATABLE

J9NLS_EXELIB_INTERNAL_HELP_XXENABLESHAREORPAH=\ \ -XX: +ShareOrphans permet compartir classes sense informaci\u00f3 de cam\u00ed d'acc\u00e9s de classe/m\u00f2dul com a orfes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the space after : (in -XX: +ShareOrphans)? I don't see it in other references to -XX:... options in this file. See for example, line 934:

J9NLS_EXELIB_INTERNAL_HELP_XXPORTABLESHAREDCACHE=\ \ -XX:+PortableSharedCache ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't control the automated translations. I could fix them manually but the spaces might come back next time. I think I'll just close this PR and we can try translations again another day and hope for a better result.

Copy link
Contributor

@keithc-ca keithc-ca May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would automation add them some places, but not others or do something different on another day?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect they are constantly fiddling with translations. Much of the earlier translation was done by humans. Only recent translations, PRs I've opened, are automated. I think we could get different results by waiting a week or two. Perhaps there is a way to report a problem, but atm I don't know how to do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing to note is that there is a translation cache. I don't believe it re-translates everything when translation is done, it looks for new things. Since I've submitted this translation now, perhaps it will be stuck this way, but we have seen older translated messages get updated on occasion, so I have some hope.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the stray, unwanted spaces, and try to report this misbehavior in hopes they won't come back.

@pshipton pshipton marked this pull request as draft May 17, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants