Update struct support in embedded libffi #19468
Merged
+654
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r30shah Draft PR up for you review |
AustinWells
force-pushed
the
master
branch
2 times, most recently
from
0a997b7
to
e2ed14f
Compare
r30shah
requested changes
May 23, 2024
|
Hi @AustinWells thanks a lot for the contribution, can I request you to fix the line endings as well (I do understand lot of this are just inherited), but would be good to get them resolved. Also as I commented, this is in a good space and given that we have tested out this with JDK, PR should be marked ready for review (Without that, wouldn't be able to merge) |
|
@r30shah I've resolved the comments as requested and fixed up the line endings/whitespace. |
AustinWells
changed the title
r30shah
requested changes
May 24, 2024
Adds support for passing struct type arguments and receiving struct type returns in libffi
- Struct arguments are now properly loaded into registers and the argument area in sys64z.s
- Struct returns are now appropriately handled in sys64z.s
- Doesn't pad argument buffer in ffi_prep_args to save space.
Signed-off-by: Austin Wells <[email protected]>
r30shah
approved these changes
May 24, 2024
|
Java8 on z/OS Build number : |
|
Internal tests passes. Merging this one. |
ChengJin01
added a commit
to ChengJin01/openj9
that referenced
this pull request
May 28, 2024
The change enables the excluded tests specific to the default library loading and struct given the related issues have been resolved via ibmruntimes/openj9-openjdk-jdk21#159 and eclipse-openj9#19468. Signed-off-by: ChengJin01 <[email protected]>
ChengJin01
added a commit
to ChengJin01/openj9
that referenced
this pull request
May 28, 2024
The change enables the excluded tests specific to the default library loading and struct given the related issues have been resolved via ibmruntimes/openj9-openjdk-jdk21#159 and eclipse-openj9#19468. Related: [Internal 441](https://github.ibm.com/runtimes/javanext/issues/441) Signed-off-by: ChengJin01 <[email protected]>
AswathySK
pushed a commit
to AswathySK/openj9
that referenced
this pull request
Jun 4, 2024
The change enables the excluded tests specific to the default library loading and struct given the related issues have been resolved via ibmruntimes/openj9-openjdk-jdk21#159 and eclipse-openj9#19468. Related: [Internal 441](https://github.ibm.com/runtimes/javanext/issues/441) Signed-off-by: ChengJin01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing struct type arguments and receiving struct type returns in libffi
- Struct arguments are now properly loaded into registers and the argument area in sys64z.s
- Struct returns are now appropriately handled in sys64z.s
- Doesn't pad argument buffer in ffi_prep_args to save space.