KubernetesWatchTask.getWatchContext and KubernetesWatchTask.createWat… #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #3077 (2024-05-20T15:38:32Z) ⚙️ JKube E2E Tests (9161048590)
|
|
Hi @manusa, This PR is ready for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3077 +/- ##
=============================================
+ Coverage 59.36% 71.02% +11.66%
- Complexity 4586 5071 +485
=============================================
Files 500 488 -12
Lines 21211 19443 -1768
Branches 2830 2501 -329
=============================================
+ Hits 12591 13810 +1219
+ Misses 7370 4419 -2951
+ Partials 1250 1214 -36 ☔ View full report in Codecov by Sentry. |
|
You should have amended the original commit. The PR has now a commit from an invalid user, so it's still not possible to merge. |
kiratkumar47
force-pushed
the
KubernetesWatchTask.getWatchContext-The-declared-Exception-exception-is-never-thrown-3054
branch
from
a9b527a
to
7e90cd4
Compare
…cherContext. The declared Exception is never thrown eclipse-jkube#3054
…ndTest, issue eclipse-jkube#3006 Signed-off-by: arman-yekkehkhani <[email protected]>
Bumps [com.mycila:license-maven-plugin](https://github.com/mathieucarbou/license-maven-plugin) from 4.4 to 4.5. - [Commits](mathieucarbou/license-maven-plugin@license-maven-plugin-4.4...license-maven-plugin-4.5) --- updated-dependencies: - dependency-name: com.mycila:license-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
…neratorIntegrationTest (3058) Signed-off-by: arman-yekkehkhani <[email protected]>
kiratkumar47
force-pushed
the
KubernetesWatchTask.getWatchContext-The-declared-Exception-exception-is-never-thrown-3054
branch
from
7e90cd4
to
220ac20
Compare
I have amended the original commit. Please check if this resolves the issue. I am new to this and would appreciate your help. |
|
|
It doesn't, at this stage, I'd advise you to close the PR and start from scratch using a fresh version of the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubernetesWatchTask.getWatchContext The declared Exception is never thrown
Description
Fixes #3054
Type of change
test, version modification, documentation, etc.)
Checklist