-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use java streams api to get rid of nested if statements in KubernetesClientUtil #3072
base: master
Are you sure you want to change the base?
Conversation
…KubernetesClientUtil Signed-off-by: Rohit Satya <[email protected]>
Eclipse JKube CI ReportStarted new GH workflow run for #3072 (2024-05-17T10:59:26Z) ⚙️ JKube E2E Tests (9127005913)
|
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3072 +/- ##
=============================================
+ Coverage 59.36% 71.02% +11.66%
- Complexity 4586 5070 +484
=============================================
Files 500 488 -12
Lines 21211 19428 -1783
Branches 2830 2496 -334
=============================================
+ Hits 12591 13798 +1207
+ Misses 7370 4417 -2953
+ Partials 1250 1213 -37 ☔ View full report in Codecov by Sentry. |
Is there unit tests that ensure that there is no regression? if not plz add unit tests |
@rohit-satya : Could you please add unit tests for this change? |
@rohanKanojia Will do |
Description
Use java streams api to get rid of nested if statements in KubernetesClientUtil
Fixes #3030
Type of change
test, version modification, documentation, etc.)
Checklist