NEPT-1701: [Poetry client] Sanitisation of text fields #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritomelo
pushed a commit
that referenced
this pull request
Jan 12, 2018
Fefaine
added a commit
that referenced
this pull request
Jan 23, 2018
* NEPT-1540: Fix nexteuropa_varnish problem with the subsites having "/" as base URL. * NEPT 1076 : Component ID 63 - Implement the new labels component : Add field formatter (#1607) * NEPT-1076: ARF-> Add field formatter for group access. * NEPT-1076: ARF-> Coding standards. * NEPT-1076: ARF-> Coding: remove ifs. * NEPT-1076: ARF-> Best practices: Set more generic machine name. * NEPT-1076: ARF-> Best practices: Set more generic label. * NEPT-1076: Update name. * NEPT-1540: Use === to compare strings because substr() can returns FALSE sometimes. * NEPT-1540: Adapt base path trim process for unit test + implement the test. * NEPT-1540: Remove composer json and lock files that are not mandatory. * NEPT-1176: Correct the url used in the logout and remove the unsupported "service" parameter. * NEPT-1426: Update fblikebutton * NEPT-683: Upgrade Wysiwyg version (#1362) * NEPT-683: Upgrade Wysiwyg version * NEPT-683: Remove unused wysiwyg patches. * NEPT-683: Update internal names of settings. * NEPT-683: Add missing dependency and remove unused hook. * NEPT-683: Added comment to clarify patch in make file. * NEPT-683: Reverted ckeditor hook removal. * NEPT-683: Upgrade module to version 2.4 & remove patch. * NEPT-683: Fix error in the module version identifier. * NEPT-683: Remove permissions which no longer exists. * NEPT-683: Update the ckeditor version expected by wysiwyg. * NEPT-683: Add comment on the hook_update. * NEPT-683: Fix the expected version in the hook_install. * NEPT-683: Fix the feed of the wysiwyg version in format by creating new function in multisite_config. * NEPT-683: Upgrading the security patch and add it in the make file. * NEPT-683: Refactor the ckeditor version setting during the cce_basic_config install and update 7221. * NEPT-683: Raplce the += approach by filling directly set the "setting" attribute of the "profile object. * NEPT-683: Remove useless empty line. * NEPT-884: Fix code style in platform-dev 2.4.x to respect QA automation rules (#1590) * NEPT-1287: Removed empty lines after inline comments. * NEPT-1288: Renamed classes. * NEPT-1291: Fixed form doc comment. * NEPT-1292: Made error message translatable. * NEPT-1293: Removed unnecesary check_plains. * NEPT-1294: Made messages translatable. * NEPT-1295: Replaced t() with get_t(). * NEPT-1294: Added missint t functions. * NEPT-1297: Made description translatable. * NEPT-1298: Added appropiate role to configuration page. * NEPT-1299: Removed db_select calls. * NEPT-1300: Replaced 'und' with LANGUAGE_NONE constant. * NEPT-1301: Moved custom js and css from hook_init to hook_page_build. * NEPT-1302: Removed calls to theme functions. * NEPT-1302: Removed calls to theme functions. * NEPT-1292: Fixed QA remarks. * NEPT-1304: Removed pattern exlusion. * NEPT-1305: Added explanation for function returns. * NEPT-1307: Removed rule. * NEPT-1308: Removed rule. * NEPT-1310: Changed feature api to api:2. * NEPT-1311: Removed unused attribute. * NEPT-1288:Added exclusion rules to prevent view classes from failing. * NEPT-1313: Added description to update hooks. * NEPT-1293: Replace "!" prefix tokens by "@" ones. * NEPT-1364: Added exclusion rule until standard is defined. * NEPT-1365: Removed extra newlines from files. * NEPT-1366: Added blank line after php tag. * NEPT-1367: Added correct identation to object operators. * NEPT-1368: Removed extra space on return comments. * NEPT-1369: Aligned equal signs. * NEPT-1371: Fixed spacing before equal sign. * NEPT-1372: Fixed function return types. * NEPT-1301: This is unrelated to this ticket but should be removed. * NEPT-1288: Added more generic exclusion and fixed several typos. * NEPT-1288: Added generic rule. * NEPT-1299: Fixed introduced QA exception. * NEPT-1304: Replaced input with values when reading from a form. * NEPT-1303: Improved rule description. (#1577) * NEPT-1305: Added explanation for function returns. * NEPT-1307: Replaced functions with Drupal wrappers. * NEPT-1300: Fixed long comment introduced during QA fixing. * NEPT-1287: Fix type where $ is missing. * NEPT-1308: Replaced or commented static paths. * NEPT-1366: Added blank line after open tag in test files. * NEPT-1313: Add more fixes on hook comments. * Revert "NEPT-1368: Removed extra space on return comments." This reverts commit 53ba6b2. * NEPT-1368: Removed rule. * NEPT-1372: Fixed errors in tests. * NEPT-1289: Remove the rule on a feature that is no longer part of the platform. * NEPT-1368: Fixed spacing problem on return comments. * NEPT-1310: remove the wrong commit of theme folders, ignore both folders. * NEPT-1369: Fix additional CS issue. * NEPT-1299: Fix additional cs issue. * NEPT-1412: Fix QA automation rules - There must be one blank line after the last USE statement. * NEPT-1313: Fix additional hook_update comment. * NEPT-1411: There must be one blank line after the namespace declaration. * NEPT-1307: Reverted drupal wrapper in laco feature. * NEPT-1301: Fixed function comments. * NEPT-1285: Removed or adapted unused and undefined variables. * NEPT-1309: Added temporary exclusion rule * NEPT-1368: Removed extra spaces. * NEPT-1307: Fixed issue with json_encode. * NEPT-1285: Added empty space after opening tag. * NEPT-1304: Fixed values array casting null to 0. * NEPT-1373: Address TypeHintMissing rule exception, remove from roadmap * NEPT-1285: Remove the extract function and replaced it with an alternative. * NEPT-1285: Use is_null(). * NEPT-1285: Update syntax, avoid assigning useless variables. * NEPT-1307: Fixed drupal_parse_url returning an array of query options. * NEPT-1376: Fixes for Parameter comment indentation must be 3 spaces. * NEPT-1310: Upgraded features to api2 following QA guidelines. * NEPT-1377: Remove rule for which we have no errors. * NEPT-1377: Removed duplicated rule and fixed errors. * NEPT-1310: Removed unnecesary code. * NEPT-1310: Cleaned up features components. * NEPT-1310: Removed unused include. * NEPT-884: Fixed QA notifications after merge. * NEPT-884: Fixed QA after merge. * NEPT-1568: Removed unnecesary checks and commented behavior. (#1693) * NEPT-1568: Removed unnecesary checks and commented behavior. * NEPT-1568: Removed default value from functions. * NEPT-1568: Align method phpdoc on its signature. * NEPT-1577: Upgrade the version of EC_EUROPA. (#1704) * NEPT-1577: Upgrade the version of EC_EUROPA. * NEPT-1577: Fix the behat test with a workaround. * NEPT-1145: Implements the user-menu in site-switcher component. (#1671) * NEPT-1445: Implements the user-menu in site-switcher component - remove the user-menu from the utility region uppon migrate. * Revert "Merge branch 'master' into nept-1145" This reverts commit 90314b7, reversing changes made to aeb914d. * Revert "Revert "Merge branch 'master' into nept-1145"" This reverts commit 19ccfaf. * NEPT-1475: Fast Track Translations feature (#1682) * NEPT-1476: Barebones for the upcoming modules (#1595) * NEPT-1476: Excluding custom, helper modules from the scope of the phpcs checks * NEPT-1476: Adding code review suggestions * NEPT-1479: New custom 'Rules' condtion to compare moderation states after transition * NEPT-1479: Improving documentation * NEPT-1479: Another dose of doc improvements * NEPT-1479: .install file * NEPT-1477: Work progress on the custom translator - barebones for further steps * NEPT-1479: Fixing dependencies typo in the *.install file * NEPT-1477: New custom entity and extensions for the new connector * NEPT-1479: New custom action for sending the review request * NEPT-1477: Changing composer.json to be able to install oe-poetry-client - dependecies issue with pimple * NEPT-1477: Starting to implement client * NEPT-1477: Enable/Disable hooks in the install file * NEPT-1531: Add OE Poetry Client to composer (#1614) * NEPT-1531: Improve composer file. * NEPT-1480: Add the main function for the translation actions/rules. * NEPT-1480: Fix code standard. * NEPT-1480: Align the functions. * NEPT-1477: Small syntax update for a better code readability. * NEPT-1477: Update in the custom controler * NEPT-1477 and NEPT-1479: Update logic. * NEPT-1480: Update code. * NEPT-1479: Adding new data types to the Rules * NEPT-1480: Add message in the job when a error appears. * NEPT-1480: Implement the loop for all languages. * NEPT-1480: Change the logic adding an array of jobs. * NEPT-1480: Fix issue with mapped language. * NEPT-1480: Fix code sniffer and improve code. * NEPT-1480: Fix callback issue and add the listener. * NEPT-1480: Integrate Poetry Behat. * NEPT-1479 + NEPT-1480: Tweaking after the merge * NEPT-1479 + NEPT-1480: Small fix * NEPT-1480: Add Behat tests. * NEPT-1481: Added event, condition and action to rules. * NEPT-1481: Added return property to action. * NEPT-1480: Remove poetry tag. * NEPT-1480: Fix and push composer.json and composer.lock. * NEPT-1480: Add the subscriber with translation and review request. * NEPT-1480: Set dynamic settings. * NEPT-1480: Add missing class. * NEPT-1481: Added rule event invokation. * NEPT-1480: Log message from DGT. * NEPT-1481: Fixed module name. * NEPT-1480: Fix actions. * NEPT-1481: Reworked condition. * NEPT-1480: Fix reference for review and translation request. * NEPT-1475: Reflecting code sniffer violations from the 2.3 branch * NEPT-1475: Condition to check the mapping entity. * NEPT-1475: Fixed faulty behat tests. * NEPT-1475: Fixed comment being too long. * NEPT-1475: Fixed phpcs errors introduced during last merge. * NEPT-1475: Fixing the secretaire variable name + implementation of the workflow code * NEPT-1475: Fixing small typo in the variable name * NEPT-1475: Extending the custom mapping entity by delay and client_action properties. * NEPT-1475: Updating composer.json + lock file. * NEPT-1475: Samll bug fix in the .install file, fixing typo in the test. * NEPT-1475: Fixing small bug in the test * NEPT-1475: Updating composer.json and .lock + loggers. * NEPT-1475: Aligning with the changes done on the 2.3 support branch * NEPT-1539: Upgrading views to version 3.18 (#1610) * NEPT-1539: Upgrading views to version 3.18. * NEPT-1539: Add patch that resolves an issue introduced in 3.18. * NEPT-1539: Add information concerning the patch added. * NEPT-1586: Remove temporary workaround for username rendering in nodes. (#1706) * NEPT-1586: Remove temporary workaround for username rendering in nodes. * NEPT-1586: Update version of atomium in the profile. * NEPT-1586: Update version of atomium in the build.propereties.dist. * NEPT-500: Remove unused module. * NEPT-1097: Fix regression caused by the renaming of the module formatters (#1554) * NEPT-1097: Fix regression caused by the renaming of the module, but not the hook. * NEPT-1097: Modify the custom module so that it uses the new template for tag. * NEPT-1097: Refactore ne_tags formatter to reflect new theme. * NEPT-1097: Removed taxonomy term formatter in favour of default formatters. * NEPT-1097: Add taxonomy term in NE tags field formater target. * NEPT-1097: Add dependency to field formatter.info. * NEPT-1097: Update field formatter. * NEPT-1097: Update field formatter so that items can be displayed properly in line. * NEPT-1097: Refactored for atomium 2.0. * NEPT-500: Remove the phpcs exception on the files that are removed. * Nept 1584: Force variable xmlsitemap_prefetch_aliases to 0. (#1703) * NEPT-1584: Force variable xmlsitemap_prefetch_aliases to 0; add a test to make sure variable xmlsitemap_prefetch_aliases is at 0. * NEPT-769: Change "date_first_day" to monday (#1651) Change "date_first_day" to monday and add a behat test. * NEPT-1507 : Fix URL variable of the media youtube template. (#1680) * NEPT-1507: Fix URL variable of the media youtube & add a test for the embedded video feature. * NEPT-589: Remove language cookie dependencies (#1678) * NEPT-1536: Upgrade module Quicktabs to version 3.7 and remove patches. (#1615) * NEPT-263: Adding patch for PHP7 compatibilty to iCalcreator library. (#1712) * NEPT-1569: Remove the tmgmt_mtec modue and its related symlink. (#1691) * Nept 500: uninstall multisite_og_navigation_tree. (#1715) * NEPT-226: Remove field_collection from core. (#1713) * NEPT-1621: Update the components in WYSIWYG - Update the logic (#1732) * NEPT-1630: Reorder hook updates sequence in cce_basic_config. (#1748) * NEPT-392: Upgrade i18n, remove patch. (#1625) * NEPT-364: Upgrade Password Policy to 2.0-alpha7. (#1741) * NEPT-754: Add logout_button test in behat feature (#1722) Nept-754: Add tests for the logout button * Nept-1224: Create behat test for Automated Logout (#1721) * NEPT-1224: Add automated logout behat feature and add wait X seconds step * NEPT-1224: Solve phpcs errors. * NEPT-1224: Solve phpcs errors. * NEPT-1224: Solve phpcs warning. * NEPT-1224: Change times for autologout_timeout and autologout_padding. Remove comment in FeatureContext.php. * NEPT-1224: Add new line at the end of the doccuments. * NEPT-445: Improve behat test on contact feature (#1743) * NEPT-466: Implement behat tests for the forums feature. * NEPT-445: Improve behat test on contact feature. * NEPT-445: scenarios from contact contrib module to contact_form feature * NEPT-445: scenarios from contact contrib module to contact_form feature * remove forum test feature from wrong branch * NEPT-445: Scenarios from contact.feature to contact_form.feature, add a user to check email and name fields are filled * NEPT-445: scenario description, scenarios merged, texts region. Comment-2401186 * NEPT-445: Add @wip_theme tag to test because of the use of regions, not working for ec_europa * NEPT-267: Upgrade diff module to latest commit. (#1667) * NEPT-1538: Feature sets: documentation index is unset when empty. (#1761) * NEPT-1640: Feedback from QA, update file_entity to version + patch. (#1759) * NEPT-1533: Hot Fix for the DGT FTT feature. (#1753) * NEPT-1038: update patch to not show the bean h2 when there is no title. (#1701) * NEPT-1107: Add a patch to Quicktab that prevents logging missing content. (#1740) * NEPT-275: Upgrade mimemail module to stable release. (#1675) * NEPT-1506: QA feedback, upgrade module and fix nr2923727. (#1763) * NEPT-483: Implement behat tests for text collapse feature (#1723) * NEPT-483: Create step to wait X seconds * NEPT-483: Add text-collapse behat test feature * NEPT-483: Add rich text * NEPT-483: Clean code in FeatureContext.php * NEPT-483: Add tag @theme_wip and comment of why it doesn't work on ec-europa theme * NEPT-483: Changed line endings to LF. (#1773) * NEPT-754: Fix line endings (#1782) * NEPT-1224: Fix line endings (#1781) * NEPT-1638: Nexteuropa varnish, trim base paths from all updated paths sent to varnish. (#1755) * NEPT-528: Remove inject_data from communities profile. (#1647) * NEPT-1246: Update the document following comments from Nicolas. (#1623) * NEPT-1361: Add a patch to prevent errors when there is no link to delete. (#1751) * NEPT-209: Remove hard coded variables on subsscriptions content types and taxonomy. (#1790) * NEPT-1677: Remove the check url feature from multisite wysiwyg and multisite drupal toolbox. (#1789) * NEPT-1453: Backport the "Sanitize HTML" enforcing in 2.4 at text format saving time. (#1784) * NEPT-1592: Avoid ec_resp error on attributes condition. (#1793) * NEPT-1183: Remove multisite_path_override. (#1783) * Nept 884 v2 (#1694) * Nept-1384 Fix QA automation rules - Data types in @param tags need to be fully namespaced ISSUE: - To follow the QA suggestion rule Drupal.Commenting.DataTypeNamespace.DataTypeNamespace we should removed. - By running phpcs fire up some errors regarding Coding standard and best practices ACTION: - Remove the rule mention above. - Run phpcs and address all outcome issue. - The solution for the most of issues are the params, vars full namespacing and typo missing - Fixed on behat context files. - Fixed on common features files. - Fixed on common custom modules files. * Nept-1383 Fix QA automation rules - The static declaration must come after the visibility declaration. https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1383 ACTION: - Remove the rule (The static declaration must come after the visibility declaration) <rule ref="Drupal.Methods.MethodDeclaration.StaticBeforeVisibility"> <exclude-pattern>*</exclude-pattern> </rule> - Fix the errors reported by phpcs * Nept-1381 Fix QA automation rules - Expected 1 newline at end of file ACTION: - Remove the rule (Expected 1 newline at end of file) - Fix newline at end of file reported by phpcs * Fix QA automation rules - Function return type is not void, but function is returning void here ##[NEPT-1380](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1380) ### Description Fix QA automation rules - Function return type is not void, but function is returning void here ### Change log - Removed: The rule <!-- Function return type is not void, but function is returning void here. --> <rule ref="Drupal.Commenting.FunctionComment.InvalidReturnNotVoid"> <exclude-pattern>*</exclude-pattern> </rule> The phpcs has not retrieve any error. ### Commands git fetch --all git checkout nept-1380 ./bin/phpcs * Fix QA automation rules - Parameter is not described in comment. ## [NEPT-1387](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1387) ### Description Fix QA automation rules - Parameter is not described in comment. ### Change log - Removed: The rule <!-- Parameter is not described in comment. --> <rule ref="Drupal.Commenting.FunctionComment.ParamMissingDefinition"> <exclude-pattern>*</exclude-pattern> </rule> - Added: The params missing. - Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the cleanup for QA AUTOMATION (NEPT-884 and NEPT-1387), this exception must exist to allow the removing of "Drupal.Commenting.FunctionComment.ParamMissingDefinition" rule and has the phpcs logs OK (all green) ### Commands git fetch --all git checkout nept-1387 ./bin/phpcs * NEPT-1388: Remove rule and update one line comment style. * NEPT-1935: Remove exception rule. * Fix QA automation rules - Return type "int | NULL" must not contain spaces. ## [NEPT-1389](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1389) ### Description Fix QA automation rules - Return type "int | NULL" must not contain spaces. ### Change log - Removed: The rule <!-- Return type "int | NULL" must not contain spaces. --> <rule ref="Drupal.Commenting.FunctionComment.ReturnTypeSpaces"> <exclude-pattern>*</exclude-pattern> </rule> - Removed: The unnecessary spaces. -Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387 and NEPT-1389), this exception must exist so when remove the rule "Drupal.Commenting.FunctionComment.ParamMissingDefinition" the phpcs is OK (all green). ### Commands git fetch --all git checkout nept-1389 ./bin/phpcs * Fix QA automation rules - Line indented incorrectly. ## [NEPT-1390](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1390) ### Description Fix QA automation rules - Line indented incorrectly. ### Change log - Removed: The rule <rule ref="Drupal.WhiteSpace.ScopeIndent.IncorrectExact"> ... </rule> - Added: The right indentation. - Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387 and NEPT-1389), this exception must exist so when remove the rule "Drupal.Commenting.FunctionComment.ParamMissingDefinition" the phpcs is OK (all green). ### Commands git fetch --all git checkout nept-1390 ./bin/phpcs * Fix QA automation rules - Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders ## [NEPT-1394](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1394) ### Description Fix QA automation rules - Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders. ### Change log - Removed: The rule <!-- Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders. --> <rule ref="Drupal.Semantics.FunctionT.ConcatString"> <exclude-pattern>*</exclude-pattern> </rule> - Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391), this exception must exist so when remove the rule the phpcs is OK (all green). ### Commands git fetch --all git checkout nept-1394 ./bin/phpcs * Fix QA automation rules - Missing file doc comment. ## [NEPT-1396](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1396) ### Description Fix QA automation rules - Missing file doc comment. ### Change log - Removed: The rule <!-- Missing file doc comment. --> <rule ref="Drupal.Commenting.FileComment.Missing"> <exclude-pattern>*</exclude-pattern> </rule> - Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391, NEPT-1396), this exception must exist so when remove the rule the phpcs is OK (all green). ### Commands git fetch --all git checkout nept-1396 ./bin/phpcs * Fix QA automation rules - Doc comment short description must start with a capital letter. ## [NEPT-1397](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1397) ### Description Fix QA automation rules - Doc comment short description must start with a capital letter. ### Change log - Removed: The rule <rule ref="Drupal.Commenting.DocComment.ShortNotCapital"> ... </rule> - Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391, NEPT-1396, NEPT-1397), this exception must exist so when remove the rule the phpcs is OK (all green). ### Commands git fetch --all git checkout nept-1396 ./bin/phpcs * Fix QA automation rules - Values usually have to run through t() for translation. ## [NEPT-1398](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1398) ### Description Fix QA automation rules - Values usually have to run through t() for translation. ### Change log - Removed: The rule <!-- Values usually have to run through t() for translation. --> <rule ref="DrupalPractice.General.OptionsT.TforValue"> <exclude-pattern>*</exclude-pattern> </rule> - Added: Wrapp all string within t function. - Added: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391, NEPT-1396, NEPT-1397), this exception must exist while removing the rule and gwt OK from the phpcs (all green). ### Commands git fetch --all git checkout nept-1396 ./bin/phpcs * Fix QA automation rules - Namespaced classes/interfaces/traits should be referenced with use statements ##[NEPT-1385](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1385) ### Description Fix QA automation rules - Namespaced classes/interfaces/traits should be referenced with use statements ### Change log - Removed: The rule <!-- Namespaced classes/interfaces/traits should be referenced with use statements. --> <rule ref="Drupal.Classes.FullyQualifiedNamespace.UseStatementMissing"> <exclude-pattern>*</exclude-pattern> </rule> - Fixed: Include the classes by using USE and namespacing - Fixed: Include the classes by using USE and namespacing - Removed: Following code review from Diogo and after agreement the exceptions have been removed. ### Commands git fetch --all git checkout nept-1385 ./bin/phpcs * NEPT-1404: Fix QA, Remove exception for @var tag fix issues. * NEPT-1410: Fix QA-Remove exception for opening brace of functions, fix issues. * Fix QA automation rules - Are you accessing field values here? Then you should use LANGUAGE_NONE instead of 'und'. ## [NEPT-1402](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1402) ### Description Fix QA automation rules - Are you accessing field values here? Then you should use LANGUAGE_NONE instead of 'und'. ### Change log - Removed: The rule <!-- Use the LANGUAGE_NONE constant. --> <!-- https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-821 --> <rule ref="DrupalPractice.General.LanguageNone.Und"> <exclude-pattern>profiles/common/themes/ec_resp/template.php</exclude-pattern> <exclude-pattern>profiles/common/modules/custom/multisite_block_carousel/multisite_block_carousel.module</exclude-pattern> <exclude-pattern>profiles/common/modules/custom/subscriptions_og/subscriptions_og.module</exclude-pattern> <exclude-pattern>profiles/common/modules/features/multisite_mediagallery_core/multisite_mediagallery_ <ex</exclude-patter <exclude-pattern>profiles/common/modules/features/multisite_mediagallery_core/multisite_mediagallery_ity.module</exclude-pattern> <exclude-pattern>profiles/common/modules/features/nexteuropa_metatags/nexteuropa_metatags.module</exclude-pattern> <exclude-pattern>profiles/common/modules/features/events/events_core/events_core.module</exclude-pattern> <exclude-pattern>profiles/common/modules/features/cce_basic_config/cce_basic_config.install</exclude-pattern> <exclude-pattern>profiles/common/modules/features/nexteuropa_geofield/nexteuropa_geofield.module</exclude-pattern> <exclude-pattern>profiles/common/modules/features/news/news_core/news_core.module</exclude-pattern> <exclude-pattern>profiles/common/modules/features/news/news_og/news_og.module</exclude-pattern> </rule> - Added: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391, NEPT-1396, NEPT-1400), this exception must exist while removing the rule and gwt OK from the phpcs (all green). - Changed: The 'und' key has been changed by LANGUAGE_NONE const as DRUPAL best practices recommended. ### Commands No comandss. * NEPT-1409: Fix QA-Remove exception for opening brace of JS functions, fix issues. * NEPT-1375: Remove the "Drupal.Commenting.FileComment.NamespaceNoFileDoc" rule and remove "@file" comments. (#1627) * Fix QA automation rules - Content missing for @var tag in member variable comment. ## [NEPT-1405](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1405) ### Description Fix QA automation rules - Content missing for @var tag in member variable comment. ### Change log - Removed: The rule <rule ref="DrupalPractice.General.LanguageNone.Und"> ... </rule> - Added: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391, NEPT-1396, NEPT-1400, NEPT-1402, NEPT-1405), this exception must exist while removing the rule and gwt OK from the phpcs (all green). - Added: The variable type form heredoc. ### Commands No comandss. * Fix QA automation rules - File appears to be minified and cannot be processed. ## [NEPT-1417](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1417) ### Description Fix QA automation rules - File appears to be minified and cannot be processed. ### Change log - Removed: The rule <!-- File appears to be minified and cannot be processed. --> <rule ref="Internal.Tokenizer.Exception"> <exclude-pattern>*</exclude-pattern> </rule> - Added: A rule to exclude nexteuropa_newsroom. ### Commands NA. * NEPT-1378: Remove unused use statements. (#1632) * NEPT-1418: Fix QA-Remove exception rule for usseless overide and add exception for newsroom module. * NEPT-1312: Removed rule. * Fix QA automation rules - Move helper functions for install file out of install file. ## [NEPT-1312](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1312) ### Description Fix QA automation rules - Move helper functions for install file out of install file. ### Change log - Removed: The rule "QualityAssurance.InstallFiles.FunctionDeclarations.NonHookFound" - Added: A rule to exclude nexteuropa_newsroom. And also swap the custom functions to an include file as suggested by QA Automation at [Install File Requirements](https://webgate.ec.europa.eu/fpfis/wikis/display/MULTISITE/Install+file+requirements#helper-functions) ### Commands NA. * Fix QA automation rules - Unused private method. ## [NEPT-1400](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1400) ### Description Fix QA automation rules - Unused private method. ### Change log - Removed: The rule 1- "DrupalPractice.Objects.UnusedPrivateMethod.UnusedMethod" 2- The private methods that are not being used. - Added: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391, NEPT-1396, NEPT-1400), this exception must exist while removing the rule and gwt OK from the phpcs (all green). ### Commands NA. * . * Fix QA automation rules - You must use "/**" style comments for a member variable comment. ## [NEPT-1391](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1391) ### Description Fix QA automation rules - Line indented incorrectly. ### Change log - Removed: The rule ref="Drupal.Commenting.VariableComment.WrongStyle" - Added: The right indentation. - Created: An exception has been set to exclude nexteuropa_newsroom module once it is not supported by Core team, so to progress with the clean up for QA AUTOMATION (NEPT-884, NEPT-1387, NEPT-1389, NEPT-1390, NEPT-1391), this exception must exist so when remove the rule the phpcs is OK (all green). - Addressed the PR comments. * - Addressed the PR comment. - Added: Re-insert the rule "" that was removed by mistake. - Added: To t function on options element that is not beeing fire up by phpcs but pick up by Gilles. * NEPT-1540: Fix nexteuropa_varnish problem with the subsites having "/" as base URL. * NEPT-1540: Use === to compare strings because substr() can returns FALSE sometimes. * NEPT-1540: Adapt base path trim process for unit test + implement the test. * NEPT-1540: Remove composer json and lock files that are not mandatory. * NEPT-1176: Correct the url used in the logout and remove the unsupported "service" parameter. * NEPT-1375: Remove the "Drupal.Commenting.FileComment.NamespaceNoFileDoc" rule and remove "@file" comments. (#1627) * NEPT-1378: Remove unused use statements. (#1632) * NEPT-1393: NEPT-1393: Fix QA automation rules "bool|FALSE Remove exception rule and update comment parameters. * NEPT-1392: Fix QA automation rules - Expected "\Drupal\DrupalDriverManager" (#1640) Fix QA automation rules - Expected "\Drupal\DrupalDriverManager" but found "\Drupal\DrupalDriverManager;" for @var tag in member variable comment * NEPT-1379: Fix QA automation rules - Tags should not be used. (#1669) * Remove the unneeded rule. * Fix QA automation rules - File appears to be minified and cannot be processed. ## [NEPT-1417](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1417) ### Description Fix QA automation rules - File appears to be minified and cannot be processed. ### Change log - Removed: The rule <!-- File appears to be minified and cannot be processed. --> <rule ref="Internal.Tokenizer.Exception"> <exclude-pattern>*</exclude-pattern> </rule> - Added: A rule to exclude nexteuropa_newsroom. - Removed exclusion rule as it is not needed anymore. * Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ## [NEPT-1405](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1405) ### Description Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ### Change log - Removed: The rule <rule ref="DrupalPractice.General.LanguageNone.Und"> ... </rule> - Removed: Block of codes related to empty value for path_auto using strongarm. Accordingly, with QA drupal standard, we should: Avoid empty strongarm values Strongarm settings shouldn't be delivered when the value is empty, especially with pathauto patterns. If it has '' value then the webmaster will change it on production it will make the feature overridden. Solution: do not put empty settings to strongarm. Find more at [QA- Strongarm](https://webgate.ec.europa.eu/fpfis/wikis/pages/viewpage.action?spaceKey=MULTISITE&title=Features+files+requirements#strongarm) - Removed uneeded exception... * Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ## [NEPT-1405](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1405) ### Description Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ### Change log - Removed: The rule <rule ref="DrupalPractice.General.LanguageNone.Und"> ... </rule> - Removed: Block of codes related to empty value for path_auto using strongarm. Accordingly, with QA drupal standard, we should: Avoid empty strongarm values Strongarm settings shouldn't be delivered when the value is empty, especially with pathauto patterns. If it has '' value then the webmaster will change it on production it will make the feature overridden. Solution: do not put empty settings to strongarm. Find more at [QA- Strongarm](https://webgate.ec.europa.eu/fpfis/wikis/pages/viewpage.action?spaceKey=MULTISITE&title=Features+files+requirements#strongarm) ### Commands NA. * Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ## [NEPT-1405](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1405) ### Description Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ### Change log - Removed: The rule <rule ref="DrupalPractice.General.LanguageNone.Und"> ... </rule> - Removed: Block of codes related to empty value for path_auto using strongarm. Accordingly, with QA drupal standard, we should: Avoid empty strongarm values Strongarm settings shouldn't be delivered when the value is empty, especially with pathauto patterns. If it has '' value then the webmaster will change it on production it will make the feature overridden. Solution: do not put empty settings to strongarm. Find more at [QA- Strongarm](https://webgate.ec.europa.eu/fpfis/wikis/pages/viewpage.action?spaceKey=MULTISITE&title=Features+files+requirements#strongarm) ### Commands NA. * Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ## [NEPT-1405](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1405) ### Description Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ### Change log - Removed: The rule <rule ref="DrupalPractice.General.LanguageNone.Und"> ... </rule> - Removed: Block of codes related to empty value for path_auto using strongarm. Accordingly, with QA drupal standard, we should: Avoid empty strongarm values Strongarm settings shouldn't be delivered when the value is empty, especially with pathauto patterns. If it has '' value then the webmaster will change it on production it will make the feature overridden. Solution: do not put empty settings to strongarm. Find more at [QA- Strongarm](https://webgate.ec.europa.eu/fpfis/wikis/pages/viewpage.action?spaceKey=MULTISITE&title=Features+files+requirements#strongarm) ### Commands NA. * Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ## [NEPT-1405](https://webgate.ec.europa.eu/CITnet/jira/browse/NEPT-1405) ### Description Fix QA automation rules - Empty strongarm settings for 'pathauto_node_blog_pattern' are not allowed. ### Change log - Removed: The rule <rule ref="DrupalPractice.General.LanguageNone.Und"> ... </rule> - Removed: Block of codes related to empty value for path_auto using strongarm. Accordingly, with QA drupal standard, we should: Avoid empty strongarm values Strongarm settings shouldn't be delivered when the value is empty, especially with pathauto patterns. If it has '' value then the webmaster will change it on production it will make the feature overridden. Solution: do not put empty settings to strongarm. Find more at [QA- Strongarm](https://webgate.ec.europa.eu/fpfis/wikis/pages/viewpage.action?spaceKey=MULTISITE&title=Features+files+requirements#strongarm) * Addressed an issue introduced by ticket nept-1391, regarding drupal user while comment a menber variable, so with stdclass phpcs was complainning so it has been changed to Drupaluser. * NEPT-1406: Fix QA automation rules - Expected 1 blank line after function. (#1670) * NEPT-1407: Coding standards : Remove exception for empty lines before… (#1674) * NEPT-1407: Coding standards : Remove exception for empty lines before function and fix. * Addressing phpcs error after merging all: - Removed extra line. - Aligned equals signed with sorrounding assignments - Change NULL to null,QA suggestion, maybe we should check this rule. - Fixed all phpcs complains after merging all custom branch into feature branch @nept-884-v2@. Please enter the commit message for your changes. Lines starting * Addressed phpcs issue will new files that has been added, so It was missing an empty line after php flag. * - Removed file doc comment to follow QA rules. - Importing class using USE keyword - Added an empty line between class declaration and first function declaration - All error addressed. * NEPT-884: Added missing include. * NEPT-884: Fixed inconsistencies on qa exception ruleset. * NEPT-884: Added missing exception for views plugin method names. * NEPT-884: Removed duplicaded rule on roadmap. * NEPT-884: Removed duplicated rules. * NEPT-884: Fix leftover QA remarks. * NEPT-884: Fix leftover QA remarks. * NEPT-884: Fix leftover QA remarks. * NEPT-884: Removing fixed update hooks to be tackled in a future ticket. * NEPT-884: Added full namespaces to comments in order to make it consisten. * NEPT-884: Moved rule exception to ruleset file. * NEPT-884: Fix comments in order to make them consistent and other minor fixes. * NEPT-884: Fixed issues after merge from release branch. * NEPT-1621: Fix notice error, make sure the specific key exist prior doing array_merge(). (#1769) * NEPT-289: Upgrade mpdf to 6.1.4. (#1686) * NEPT-1661: DGT FTT - Dynamic Requester Code - Counter logic (#1779) * NEPT-1661: Initial commit for the fix to test on VPS * NEPT-1661 - New counter logic for dynamic requester codes + minor tweaks * NEPT-1661: Minor comment fix. * NEPT-1661: Aligning the code standards between 2.3 and master * NEPT-1661: Tweaking the translation request functions. * NEPT-1661: Tweaking the translation request functions. * NEPT-1661: Putting the @wip tag on the send translation request scenario * NEPT-1701: Update Poetry client to 0.3.5 and re-generate composer.lock. (#1807) * NEPT-1617: Review and cleanup component. - Part 2. (#1749) * NEPT-1705: Remove module that is only used by farnet and should move to custom. (#1800) * NEPT-1591: Merge fast track functionalities in NEPT-1590, NEPT-1562, NEPT-1589 and NEPT-1588 (#1738) * NEPT-1588: Add the possibility to customize the variable 'WorkflowCode' into the action + behat test. (#1707) * NEPT-1590: Checking the translator type to correct dispatch upcoming translations. (#1710) * NEPT-1590: Checking the translator type to correct dispatch upcoming translations. * NEPT-1590: Change the logic of the implementation. * NEPT-1590: Improve code with more information for log and better use of use statement * Nept 1562 master (#1719) * NEPT-1562: Added language parameter to request translation action. * NEPT-1562: Added behat tests for optional language parameter. * NEPT-1562: Change description and improve code for behat test. * NEPT-1589: Add the delay + behat test. (#1734) * NEPT-1589: Renamed variable and added behat to test custom field. * NEPT-1589: Moved test to wip. * NEPT-1589: Remove the @wip in the behat test. * NEPT-1589: Add delay for all fast-track's behat test. * NEPT-1589: Fix the scenario 'Request using custom date field.'. * NEPT-1589: Fix the issue with the creation of a field and a rule. * NEPT-1589: Split the behat into 2 files. * NEPT-1591: Fixed tests. * NEPT-1591: Removed debugging code. * NEPT-1591: Merge fast track functionalities from master (#1818) * NEPT-1591: Merge fast track functionalities in NEPT-1590, NEPT-1562, NEPT-1589 and NEPT-1588 (#1738) * NEPT-1588: Add the possibility to customize the variable 'WorkflowCode' into the action + behat test. (#1707) * NEPT-1590: Checking the translator type to correct dispatch upcoming translations. (#1710) * NEPT-1590: Checking the translator type to correct dispatch upcoming translations. * NEPT-1590: Change the logic of the implementation. * NEPT-1590: Improve code with more information for log and better use of use statement * Nept 1562 master (#1719) * NEPT-1562: Added language parameter to request translation action. * NEPT-1562: Added behat tests for optional language parameter. * NEPT-1562: Change description and improve code for behat test. * NEPT-1589: Add the delay + behat test. (#1734) * NEPT-1589: Renamed variable and added behat to test custom field. * NEPT-1589: Moved test to wip. * NEPT-1589: Remove the @wip in the behat test. * NEPT-1589: Add delay for all fast-track's behat test. * NEPT-1589: Fix the scenario 'Request using custom date field.'. * NEPT-1589: Fix the issue with the creation of a field and a rule. * NEPT-1589: Split the behat into 2 files. * NEPT-1591: Fixed tests. * NEPT-1591: Removed debugging code. * NEPT-1591: Fix CS errors * NEPT-1591: Fix comment * NEPT-1044: Internal content tokens display as text in a wysiwyg table (#1684) * NEPT-1044: Set tags in which the placeholder tag can be included + replace "dtd" boolean values bu integer ones. * NEPT-1044: Introduce a new test checking the insertion of a internal link. * NEPT-1044: Duplicate the new test checking the insertion of a internal link to be compatible with ec_europa. * NEPT-1044: Add assertion test on the container for the step related to the embedded link + align the use of bovigo functions. * NEPT-1044: Include the duplicated steps in the background and keep theme specific part in scenario. * NEPT-1044: Adapt the css selector in the ec_europa secnario to follow the new theme implementation. * Revert "NEPT-1591: Merge fast track functionalities from master (#1818)" This reverts commit bb63068. * NEPT-1044: Resolve cs issues. * NEPT-355: Upgrade module to latest stable version. (#1798) * NEPT-1159: Update ressource for mpdf library in makefile. (#1802) * NEPT-1583: Upgrade Better Exposed Filters to 3.5. (#1778) * NEPT-1159: merge master 2.5 (#1834) * NEPT-355: Upgrade module to latest stable version. (#1798) * NEPT-1159: Update ressource for mpdf library in makefile. (#1802) * Revert "NEPT-1159: merge master 2.5 (#1834)" This reverts commit af52e9c. * Upgrade metatag module version 1.21 to 1.22 (#1830) Upgraded metatag module and removed the patch as is not needed anymore * NEPT-274: Updated migrate module to version 7.x-2.8+19-dev & add patch. (#1774) * NEPT-1494: Sanitize HTML filter: Remove the central configuration feature (#1660) * NEPT-1753: Concatatenate the LANGUAGE_NONE instead of put between doubble quotes. (#1845) * NEPT-1750: Add a patch that fix the entityreference language regression. (#1842) * NEPT-1761: Remove the entityreference page obsolete for the version 1.5. * NEPT-1761: Fix CS in multisite_drupal_toolbox.install (anonymous function rule). * NEPT-1704: Add patch to resolve message to throw errors on cron. (#1799) * NEPT-1704: Add patch to resolve message to throw errors on cron * NEPT-266: Add a patch to resolve PHP7 issue. (#1835) * NEPT-155: Update CHOSEN module to stable release 2.1 . (#1797) * NEPT-1213: Fixed failing wip test. (#1827) NEPT-1213: Fixed failing wip test. (#1827) * NEPT-1622: Enable system main block on ec_europa theme migration (#1847) * NEPT-1622: Enable system main block on the ec_europa theme * NEPT-1622: Format code for a better readability and compliance with what is already done. * NEPT-1756: Hide the label of the europasearch form by default. (#1859)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEPT-1701
Description
This PR will update Poetry client to version 0.3.5, which contains sanitisation fix as per ec-europa/oe-poetry-client#68
Change log
Commands
As the release package already have embed libraries there is no need to run any additional command.