Issue #62: Refactor withXml().

src/Messages/AbstractMessage.php

@@ -127,4 +127,20 @@ public function setMessageId($messageId)
     {
         $this->messageId = $messageId;
     }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function withXml($xml)
+    {
+        $this->setRaw($xml);
+        $parser = $this->getParser();
+        $parser->addXmlContent($xml);
+
+        $xml = $parser->getOuterContent('POETRY/request/demandeId');
+        $this->getIdentifier()->withXml($xml);
+        $this->setMessageId($parser->getAttribute('POETRY/request', 'id'));
+
+        return $this;
+    }
 }

src/Messages/ComponentInterface.php

@@ -30,10 +30,36 @@ public function getAttributes();
      * Construct component from given array.
      *
      * @param array $properties
+     *
      * @return $this
      */
     public function withArray(array $properties);
 
+    /**
+     * Set message or component internal properties given its XML representation.
+     *
+     * @param string $xml
+     *
+     * @return $this
+     */
+    public function withXml($xml);
+
+    /**
+     * Get raw XML.
+     *
+     * @return string
+     */
+    public function getRaw();
+
+    /**
+     * Set raw XML.
+     *
+     * @param string $raw
+     *
+     * @return $this
+     */
+    public function setRaw($raw);
+
     /**
      * @param \Symfony\Component\Validator\Mapping\ClassMetadata $metadata
      */

src/Messages/Components/AbstractComponent.php

@@ -28,27 +28,12 @@ public function getAttributes()
     }
 
     /**
-     * Set a message or a component internal properties given its XML representation.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
+     * {@inheritdoc}
      */
     public function withXml($xml)
     {
         $this->setRaw($xml);
 
-        return $this->parseXml($xml);
+        return $this;
     }
-
-    /**
-     * Parse a XML string into a set of properties.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    abstract protected function parseXml($xml);
 }

src/Messages/Components/Contact.php

@@ -132,7 +132,7 @@ public function setEmail($email)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/Details.php

@@ -382,7 +382,7 @@ public function setReferenceFilesRemark($referenceFilesRemark)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/Identifier.php

@@ -269,7 +269,7 @@ public function getGroupSequence()
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/ReferenceDocument.php

@@ -248,7 +248,7 @@ public function setFile($file)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/ReturnAddress.php

@@ -202,7 +202,7 @@ public function setRemark($remark)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/Source.php

@@ -296,7 +296,7 @@ public function setFile($file)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/SourceLanguage.php

@@ -80,7 +80,7 @@ public function setPages($pages)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/Status.php

@@ -200,7 +200,7 @@ public function setMessage($message)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/Target.php

@@ -306,7 +306,7 @@ public function withReturnAddress()
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
         $parser = $this->getParser();
         $parser->addXmlContent($xml);

src/Messages/Components/TargetReturnAddress.php

@@ -9,7 +9,6 @@
  */
 class TargetReturnAddress extends ReturnAddress
 {
-
     /**
      * {@inheritdoc}
      */

src/Messages/MessageAwareInterface.php

@@ -2,8 +2,6 @@
 
 namespace EC\Poetry\Messages;
 
-use EC\Poetry\Messages\MessageInterface;
-
 /**
  * Interface MessageAwareInterface
  *

src/Messages/Notifications/AbstractNotification.php

@@ -14,7 +14,6 @@
  */
 abstract class AbstractNotification extends AbstractMessage implements ParserAwareInterface, EventSubscriberInterface
 {
-
     /**
      * {@inheritdoc}
      */
@@ -31,32 +30,4 @@ public static function getSubscribedEvents()
      * @return mixed
      */
     abstract public function onParseNotification(ParseNotificationEvent $event);
-
-    /**
-     * Set a message or a component internal properties given its XML representation.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    public function withXml($xml)
-    {
-        $this->setRaw($xml);
-
-        return $this->parseXml($xml);
-    }
-
-    /**
-     * Parse a XML string into a set of properties.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    protected function parseXml($xml)
-    {
-        return $this;
-    }
 }

src/Messages/Notifications/StatusUpdated.php

@@ -43,16 +43,13 @@ public function onParseNotification(ParseNotificationEvent $event)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
+        parent::withXml($xml);
+
         $parser = $this->getParser();
         $parser->addXmlContent($xml);
 
-        $xml = $parser->getOuterContent('POETRY/request/demandeId');
-        $this->getIdentifier()->withXml($xml);
-
-        $this->setMessageId($parser->getAttribute('POETRY/request', 'id'));
-
         $parser->eachComponent("POETRY/request/status", function (Parser $component) {
             $this->withStatus()
               ->setParser($this->getParser())

src/Messages/Notifications/TranslationReceived.php

@@ -41,16 +41,13 @@ public function onParseNotification(ParseNotificationEvent $event)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
+        parent::withXml($xml);
+
         $parser = $this->getParser();
         $parser->addXmlContent($xml);
 
-        $xml = $parser->getOuterContent('POETRY/request/demandeId');
-        $this->getIdentifier()->withXml($xml);
-
-        $this->setMessageId($parser->getAttribute('POETRY/request', 'id'));
-
         $parser->eachComponent("POETRY/request/attributions", function (Parser $component) {
             $this->withTarget()
               ->setParser($this->getParser())

src/Messages/ParserAwareInterface.php

@@ -15,15 +15,13 @@ interface ParserAwareInterface
      * Get Parser property.
      *
      * @return \EC\Poetry\Services\Parser
-     *   Property value.
      */
     public function getParser();
 
     /**
      * Set Parser property.
      *
      * @param \EC\Poetry\Services\Parser $parser
-     *   Property value.
      *
      * @return $this
      */

src/Messages/Requests/AbstractRequest.php

@@ -52,32 +52,4 @@ public function getTemplate()
      * @return string
      */
     abstract public function getType();
-
-    /**
-     * Set a message or a component internal properties given its XML representation.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    public function withXml($xml)
-    {
-        $this->setRaw($xml);
-
-        return $this->parseXml($xml);
-    }
-
-    /**
-     * Parse a XML string into a set of properties.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    protected function parseXml($xml)
-    {
-        return $this;
-    }
 }

src/Messages/Requests/CreateTranslationRequest.php

@@ -9,6 +9,7 @@
 use EC\Poetry\Messages\Traits\WithReturnAddressTrait;
 use EC\Poetry\Messages\Traits\WithSourceTrait;
 use EC\Poetry\Messages\Traits\WithTargetsTrait;
+use EC\Poetry\Services\Parser;
 use EC\Poetry\Services\Settings;
 use Symfony\Component\Validator\Mapping\ClassMetadata;
 use Symfony\Component\Validator\Constraints as Assert;

src/Messages/Responses/AbstractResponse.php

@@ -12,7 +12,6 @@
  */
 abstract class AbstractResponse extends AbstractMessage implements ResponseInterface
 {
-
     /**
      * {@inheritdoc}
      */
@@ -29,32 +28,4 @@ public static function getSubscribedEvents()
      * @param \EC\Poetry\Events\ParseResponseEvent $event
      */
     abstract public function onParseResponse(ParseResponseEvent $event);
-
-    /**
-     * Set a message or a component internal properties given its XML representation.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    public function withXml($xml)
-    {
-        $this->setRaw($xml);
-
-        return $this->parseXml($xml);
-    }
-
-    /**
-     * Parse a XML string into a set of properties.
-     *
-     * @param string $xml
-     *      XML string.
-     *
-     * @return \EC\Poetry\Messages\MessageInterface|\EC\Poetry\Messages\ComponentInterface
-     */
-    protected function parseXml($xml)
-    {
-        return $this;
-    }
 }

src/Messages/Responses/Status.php

@@ -41,16 +41,13 @@ public function onParseResponse(ParseResponseEvent $event)
     /**
      * {@inheritdoc}
      */
-    protected function parseXml($xml)
+    public function withXml($xml)
     {
+        parent::withXml($xml);
+
         $parser = $this->getParser();
         $parser->addXmlContent($xml);
 
-        $xml = $parser->getOuterContent('POETRY/request/demandeId');
-        $this->getIdentifier()->withXml($xml);
-
-        $this->setMessageId($parser->getAttribute('POETRY/request', 'id'));
-
         $parser->eachComponent("POETRY/request/status", function (Parser $component) {
             $this->withStatus()
                 ->setParser($this->getParser())

src/Messages/Traits/ParserAwareTrait.php

@@ -31,10 +31,14 @@ public function getRaw()
 
     /**
      * @param string $raw
+     *
+     * @return $this
      */
     public function setRaw($raw)
     {
         $this->raw = $raw;
+
+        return $this;
     }
 
     /**