update go to 1.22 #3963
Draft
update go to 1.22 #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcb
commented
Apr 1, 2024
| @@ -305,7 +305,7 @@ lint-changelog: | |||
| # debugger builds the earthly debugger and saves the artifact in build/earth_debugger | |||
| debugger: | |||
| FROM +code | |||
| ENV CGO_ENABLED=0 | |||
| ENV CGO_ENABLED=1 | |||
There was a problem hiding this comment.
from the 1.22 Release notes:
go build commands that invoke the linker now error out if an external (C) linker will be used but cgo is not enabled. (The Go runtime requires cgo support to ensure that it is compatible with any additional libraries added by the C linker.)
There was a problem hiding this comment.
because we make use of -linkmode external
Signed-off-by: Alex Couture-Beil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.