Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update to guide on dropping satellite cache #3282

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brandonSc
Copy link
Contributor

@brandonSc brandonSc commented Sep 22, 2023

Feedback from a user who didn't realize the satellite need to be asleep first.

@brandonSc brandonSc requested a review from a team as a code owner September 22, 2023 13:05

Running the `update` command with `--drop-cache` will relaunch the instance with an empty cache volume.
Note that this operation can take a while, and the satellite may also receive any available updates during the process.
The satellite must also be in a sleep state first, you can force a satellite to sleep by running `earthly satellite sleep`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just make it sleep automatically? That would be a nicer UX.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea. I think it would make sense for earthly cli to drive that, and perhaps ask the user if they want to force it asleep before proceeding

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better if it's not interactive.. maybe it fails, unless --force is used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonSc we ran into this use-case today where a user needed to do a --drop-cache on a shared satellite. Even chaining two commands together, e.g. earthly satellite sleep my-sat && earthly satellite update --drop-cache my-sat didn't always work as other users (or the CI) would cause a wake to occur before the second command was executed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... so a client-side-only solution would not be enough. We need the server to support this atomically.

Copy link
Collaborator

@alexcb alexcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Vlad's suggesting on having it auto-sleep.

(I'm mostly commenting here to prevent future daily notifications that this PR is still open)

@alexcb
Copy link
Collaborator

alexcb commented Jan 17, 2024

I'm going to convert this to a draft since it's blocked by code-change.

@alexcb alexcb marked this pull request as draft January 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants