fix(sales invoice): get healthcare items from clinical procedure #394
+73
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamburro92
requested review from
akurungadam and
akashkrishna619
as code owners
tamburro92
changed the title
tamburro92
changed the title
|
ok now I have read the rule about "commitlint"... |
@tamburro92 ithe changes you did in the title need to be done in the commit messages. Also linters issue need to be solved |
tamburro92
force-pushed
the
version-15-hotfix
branch
from
eef8307
to
c34d797
Compare
tamburro92
force-pushed
the
version-15-hotfix
branch
from
c34d797
to
3879f83
Compare
|
ok I'm done |
|
changing target to base branch to develop as this will be appicable to v14 as well |
akashkrishna619
force-pushed
the
version-15-hotfix
branch
from
7777e59
to
3879f83
Compare
|
@tamburro92 can you test this with other invoicing as well? (Service Request/ Medication Request / Encounter etc..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a Clinical Procedure billable ad use a custom Item Code, instead of procedure name same, fetch the healthcare item from Invoice Sales will fail because it won't find the right item code.
To fix you have to retrieve, together the procedure name, the right item code.