Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated XQueryParser #2

Closed
wants to merge 1 commit into from
Closed

Conversation

ccheraa
Copy link

@ccheraa ccheraa commented Aug 9, 2022

I have updated the XQueryParser with the latest version available at https://www.bottlecaps.de/rex/ which conforms to W3C standards.

fixes eXist-db/eXide#224

This open source contribution to the xqlint project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov.

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by manually checking out this branch to eXide's support subdirectory (and temporarily renaming the original submodule). I can confirm that this fixes the xqlint problems that I reported in the linked issue.

@joewiz
Copy link
Member

joewiz commented Aug 13, 2022

@ccheraa Two questions:

  1. I performed a diff between the lib/XQueryParser.ebnf in your PR and xquery-31.ebnf retrieved from https://www.bottlecaps.de/rex/xquery-31.ebnf, and 2 differences appeared. Could you explain why these differences are present?
  2. Could you describe the procedure you used to generate the lib/XQueryParser.js file (or link to where the directions live)? I ask in case we ever need to perform this procedure again.

@ccheraa
Copy link
Author

ccheraa commented Aug 16, 2022

@joewiz I found some issues with the PR as it is, I would like to fix them first.

@ccheraa ccheraa closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xqlint error causes "run test" to silently fail
2 participants