Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] test on Java 11 #5304

Draft
wants to merge 1 commit into
base: develop-6.x.x
Choose a base branch
from
Draft

Conversation

line-o
Copy link
Member

@line-o line-o commented May 13, 2024

Description:

Test on Java 11

Reference:

Type of tests:

Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik / have seen, java11 causes an issue runtime (tar.gz) due to a signing issue/inconsistency. Only one jar file has this issue.

@adamretter
Copy link
Contributor

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

@reinhapa
Copy link
Member

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

@adamretter unfortunately JDK 8 is no longer available for the Mac OS Github action...

@adamretter
Copy link
Contributor

@adamretter unfortunately JDK 8 is no longer available for the Mac OS Github action...

Is it not possible to have a step that install a JDK? If I recall there is even a pre-build step for this in the GitHub Marketplace that can be used

@dizzzz
Copy link
Member

dizzzz commented May 14, 2024

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

I was not aware of that..... or maybe I am. Any idea why?

@reinhapa
Copy link
Member

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

I was not aware of that..... or maybe I am. Any idea why?

I just ask myself on how much effort are we willing to invest into that branch or should we try getting the next version out of the door?

@line-o
Copy link
Member Author

line-o commented May 16, 2024

Runtime of tests was reasonable between 19 to 27 minutes for the entire test suite on java 11.
If there is a known slow-down of exist-db on java 11 I would like to see an issue with some more details to be shared.
I would also like to add that we do use the java setup action.

In order for us to make sure that the existdb compiles and runs on java 8 as well we could add a separate test on java8 on linux workflow. How does that sound?

@adamretter
Copy link
Contributor

I don't understand the point of this. eXist-db 6 targets Java 8, so changing CI to Java 11 makes no sense

@reinhapa
Copy link
Member

I don't understand the point of this. eXist-db 6 targets Java 8, so changing CI to Java 11 makes no sense

@adamretter I think using Java 11 to produce Java 8 byte code should be still ok instead of having investing a lot of time to handle an alternative Java setup instead. I think it would be better to consentrate on the next release instead and not wasting to much time in doing work-arounds for no longer supported build JDKs IMHO...

@dizzzz
Copy link
Member

dizzzz commented Jul 30, 2024

@dizzzz
Copy link
Member

dizzzz commented Sep 20, 2024

I read/hear that the performance decline of java11 has been addresses in the JDK some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants