Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] outline view in sidebar #711

Merged
merged 2 commits into from
Aug 24, 2024
Merged

[bugfix] outline view in sidebar #711

merged 2 commits into from
Aug 24, 2024

Conversation

line-o
Copy link
Member

@line-o line-o commented Aug 20, 2024

The outline route returned statuscode 404 because it is in fact a post request and only get was allowed in the controller.

The outline route returned statuscode 404 because it is in fact a post request and only get was allowed in the controller.
@line-o
Copy link
Member Author

line-o commented Aug 20, 2024

@dizzz here is the PR for the issue you reported yesterday.

@line-o line-o requested review from joewiz, dizzzz, duncdrum and a team August 20, 2024 10:38
Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the 404 in the current version and that the PR restores the feature. Thanks @line-o!

@joewiz joewiz merged commit e997dc7 into develop Aug 24, 2024
4 checks passed
@joewiz joewiz deleted the fix/outline branch August 24, 2024 16:53
@joewiz
Copy link
Member

joewiz commented Aug 26, 2024

I'd like to issue a new release based on this but noted a CI failure after merging the PR - see #651 (comment). I haven't had time to dig into this to see if it's a real problem or a problem related to this PR. I'd be interested in others' opinions.

@line-o
Copy link
Member Author

line-o commented Aug 27, 2024

It is really just a flaky test that passes usually on the second run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants