Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Buffer.from() when writing a file #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggorlen
Copy link
Contributor

@ggorlen ggorlen commented Apr 18, 2024

Running the JS file download snippet in Node 20 gave me:

Uncaught:
TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ArrayBuffer

on writeFileSync.

But using Buffer.from(buffer) fixed the issue and wrote the CSV file successfully. I haven't tested this extensively since I'm working with a remote client who's using the library on his end, so more validation that this change makes sense would be good before merging (this may be specific to our text file use case).

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: b1fbe6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ValentaTomas
Copy link
Member

Hey @ggorlen, thank you for catching this and opening the PR!
We will check this out 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants