Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update dayjs configuration after modifying the start day of the week #1

Merged
merged 1 commit into from
May 24, 2024

Conversation

haydenull
Copy link

@haydenull haydenull commented May 23, 2024

Hello, thank you for your PR (haydenull#296). I finally have time to work on it.​

Since it's hard to describe in words, I made a new commit. I'm not very familiar with open source collaboration, so if this approach is not reasonable, please feel free to let me know your thoughts.​

Here are some suggested changes:​

  1. Since the dayjs library previously had logic for setting the start of the week and used number types, I unified the related types to number.​
  2. Update dayjs configuration after modifying the start of the week.​
  3. Modify how default values are handled.

@e-zz e-zz merged commit 464577b into e-zz:feat/start-of-week May 24, 2024
@e-zz
Copy link
Owner

e-zz commented May 24, 2024

Hi, great to have you back! You're doing it perfectly. I've just merged the changes, and now it's ready for shipping.
Thanks!

@haydenull haydenull deleted the feat/start-of-week branch June 10, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants