Dropped Courses #2262
Draft
Dropped Courses #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fekoch
force-pushed
the
991/dropped-courses
branch
from
6545c8d to
9ea80f3
Compare
fekoch
force-pushed
the
991/dropped-courses
branch
3 times, most recently
from
d91a83b to
2f42c54
Compare
fekoch
force-pushed
the
991/dropped-courses
branch
from
2f42c54 to
e2e836e
Compare
evap/evaluation/models.py
Outdated
| Questionnaire.objects.active_dropout_questionnaire().update(is_active_dropout_questionnaire=False) | ||
| self.is_active_dropout_questionnaire = True | ||
| self.save() | ||
| # TODO@Felix: why does this not work [wip] |
There was a problem hiding this comment.
I think the (unique=True, blank=True, null=True) tri-state approach forces us to have at most one instance with value True and all other instance with value None/NULL. The update above sets it to False, which would give it a unique validation failure. Guess that's one issue here
| @@ -162,6 +163,12 @@ def general_questionnaires(self): | |||
| def contributor_questionnaires(self): | |||
| return super().get_queryset().filter(type=Questionnaire.Type.CONTRIBUTOR) | |||
|
|
|||
| def dropout_questionnaires(self): | |||
There was a problem hiding this comment.
If you're touching these and it's no trouble, it would probably be nice if you could also add the return type annotation (-> QuerySet[Questionnaire] or whatever it should be)
(same for the views below that return HttpResponse. It's a bit annoying, but for backwards compatibility, no annotation always means "Any", even if the method always returns some specific type. I wonder if mypy issue 4409 will one day be implemented.)
evap/evaluation/models.py
Outdated
Comment on lines
242
to
243
| if self.type != Questionnaire.Type.DROPOUT: | ||
| raise ValueError("Can only set DROPOUT-type Questionnaires as active dropout questionnaire.") |
There was a problem hiding this comment.
probably fair to just use an assertion -- or do we expect this to ever happen for a correct program execution?
fekoch
force-pushed
the
991/dropped-courses
branch
from
c24d5dd to
178fc31
Compare
fekoch
force-pushed
the
991/dropped-courses
branch
from
0c1711f to
2f3043b
Compare
fekoch
commented
Oct 28, 2024
fekoch
force-pushed
the
991/dropped-courses
branch
2 times, most recently
from
dc783bf to
96e9dc7
Compare
fekoch
force-pushed
the
991/dropped-courses
branch
2 times, most recently
from
1fa6eb3 to
5a312ec
Compare
fekoch
force-pushed
the
991/dropped-courses
branch
5 times, most recently
from
2cb0daf to
cfcf4fd
Compare
fekoch
commented
Dec 2, 2024
janno42
reviewed
Dec 16, 2024
Comment on lines
+8
to
+15
| {% blocktranslate %} | ||
| If you mark this course as dropped, you can still give feedback like normal, but your answers will only | ||
| be visible to contributors. | ||
| {% endblocktranslate %} | ||
| <br> | ||
| {% blocktranslate %} | ||
| You will not be able to vote for this course afterwards. | ||
| {% endblocktranslate %} |
There was a problem hiding this comment.
I think this would be fine
Suggested change
| {% blocktranslate %} | |
| If you mark this course as dropped, you can still give feedback like normal, but your answers will only | |
| be visible to contributors. | |
| {% endblocktranslate %} | |
| <br> | |
| {% blocktranslate %} | |
| You will not be able to vote for this course afterwards. | |
| {% endblocktranslate %} | |
| {% blocktranslate %} | |
| If you mark this course as dropped, you will still be able to provide feedback as usual. However, you can only submit the questionnaire once. | |
| {% endblocktranslate %} |
The typing HttpRequest also allows for AnonymousUser as request.user. In the future, we probably should add a custom HttpRequest class that correctly states that request.user must be a UserProfile.
fekoch
force-pushed
the
991/dropped-courses
branch
from
cfcf4fd to
0f5c592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #991
(@janno42) As discussed, we want:
A setting "DROPOUT_QUESTIONNAIRE_ID" to set which questionnaire should be shown when using the drop-out function.