Remove flaky contact modal tests #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
remove-flaky-ts-test
branch
from
c9bc751 to
6bb1b09
Compare
|
Do we not want to skip instead of removing it? |
|
I'd say we don't want dead code in the repo. It's not like we're waiting for an update on a dependency or something, we just can't get it to work. If we disable it, it will likely just rot along untested and thus stop working for many other reasons. Would you prefer skipping/disabling? |
|
My thought was that we will see "1 skipped" and not forget about it, but we can also open an issue or so. Dead code is also a point, I am fine with either of the two options |
niklasmohrin
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1848.