This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Added unicode progress bar #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yermulnik
reviewed
Jan 29, 2023
| ```sh | ||
| function progress () { | ||
| local symbols=(" " "\u258F" "\u258E" "\u258D" "\u258C" "\u258B" "\u258A" "\u2589" "\u2588") | ||
| local n=$(($1/8)) |
There was a problem hiding this comment.
Why not define 8, which is used multiple times, dynamically like e.g. length=$((${#symbols[@]}-1))?
There was a problem hiding this comment.
There is no chance that unicode character table will change in future to have something else, thus 8 is a true constant here.
In the same time, determining array length on every function call will eat some CPU on every execution and give no value.
(although I completely agree with gut instinct of "constant that is > 1 should be named and computed once" - this is very good default assumption that makes perfect sense in 90-99% cases)
Wessaaa
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice book to read, thanks @dylanaraps !
This PR contains a little trick of mine that combines unicode characters into smoother variant of progress bar. Sending PR in hope you will consider it a meaningful contribution to a book.