Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #16 #73

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Issue #16 #73

wants to merge 5 commits into from

Conversation

ndrean
Copy link
Contributor

@ndrean ndrean commented Oct 28, 2022

Update V2: Simplification of error output -> coveralls 96%

@nelsonic
Copy link
Member

@SimonLab could you please take a look at this when you get a few mins. 🙏
Just so this work is not lost and we can also then take a look at the next PR in the Queue ... #75

@gf3 gf3 mentioned this pull request Jan 24, 2023
Merged
@nelsonic nelsonic assigned ndrean and unassigned SimonLab Jan 27, 2023
@nelsonic
Copy link
Member

nelsonic commented Feb 6, 2023

@ndrean if you have time, please fix merge-conflicts and re-assign for review. 🙏

@ndrean
Copy link
Contributor Author

ndrean commented Feb 13, 2023 •
edited
Loading

Should I upgrade to Phoenix 1.7 (for the Readme) where you don't use Views anymore? It seems easy.

Screenshot 2023-02-13 at 11 07 02

@nelsonic nelsonic mentioned this pull request Feb 13, 2023
Open
@nelsonic
Copy link
Member

@ndrean yeah, we should consider updating the demo app: dwyl/elixir-auth-google-demo#20
And then with that, we can update the README.md. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndrean ndrean

Labels
enhancement New feature or request in-progress merge-conflicts technical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndrean @nelsonic @SimonLab