Update .clang-format #103
Open
Update .clang-format #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change ColumnLimit to 80, otherwise it will try to use as much space as possible * Change AccessModifierOffset: -3 to make it consistent with Google style
randomir
reviewed
Oct 28, 2020
| NamespaceIndentation: Inner | ||
|
|
||
| # Scaled by a factor of 2 such that the base indent is 4 | ||
| AccessModifierOffset: -2 | ||
| AccessModifierOffset: -3 |
There was a problem hiding this comment.
Is Google's style "indent by one", or "indent by half indent width"?
I have always interpreted it as the latter, but have never checked.
There was a problem hiding this comment.
https://google.github.io/styleguide/cppguide.html#Class_Format says "indent by 1", though of course they also say "indent by 2". FWIW, https://github.com/google/styleguide complains about private/public/etc being 2, but not about the overall indent being 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #90