Add jupyter-server-proxy support
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomir
force-pushed
the
add-jupyter-server-proxy-support
branch
from
0c3d3c5
to
990e68d
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 87.79% 88.14% +0.34%
==========================================
Files 8 8
Lines 754 776 +22
==========================================
+ Hits 662 684 +22
Misses 92 92
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Has to be configured by setting `DWAVE_INSPECTOR_JUPYTER_SERVER_PROXY_EXTERNAL_URL` env var.
randomir
force-pushed
the
add-jupyter-server-proxy-support
branch
from
990e68d
to
88907a8
Compare
arcondello
reviewed
Dec 13, 2022
Important to end with slash, otherwise page static resources will just strip the leaf item from URL (i.e. the port number).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #144.
Support for relative path in React app pending and will be fixed with #146.