Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Expression::fix_variables() for quadratic expressions #1352

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix Expression::fix_variables() for quadratic expressions #1352

merged 1 commit into from
Jul 6, 2023

Conversation

arcondello
Copy link
Member

Closes #1351

@arcondello arcondello added the bug label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #1352 (4128012) into main (760b693) will increase coverage by 0.10%.
The diff coverage is 98.30%.

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   94.97%   95.08%   +0.10%     
==========================================
  Files          95       95              
  Lines        9852     9902      +50     
==========================================
+ Hits         9357     9415      +58     
+ Misses        495      487       -8
Impacted Files Coverage Δ
dimod/include/dimod/constrained_quadratic_model.h 94.11% <92.30%> (+3.20%) ⬆️
dimod/include/dimod/expression.h 87.61% <100.00%> (+0.17%) ⬆️
...estscpp/tests/test_constrained_quadratic_model.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

alexzucca90
alexzucca90 approved these changes Jul 6, 2023
View reviewed changes
Copy link

@alexzucca90 alexzucca90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arcondello arcondello merged commit a8a7ee8 into dwavesystems:main Jul 6, 2023
@arcondello arcondello deleted the fix/CQM.fix_variables branch July 6, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzucca90 alexzucca90 alexzucca90 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixing variables on quadratic expression causes memory errors.
2 participants
@arcondello @alexzucca90