Improve the performance of CQM.fix_variables() #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
force-pushed
the
fix-variables-copy
branch
from
eee38ca
to
20d778d
Compare
arcondello
requested review from
mhlr and
randomir
and removed request for
mhlr
randomir
reviewed
Apr 17, 2023
Comment on lines
548
to
549
| new_constraint.mark_discrete(old_constraint_ptr->marked_discrete() && | ||
| old_constraint_ptr->is_onehot()); |
There was a problem hiding this comment.
Should we test here if a binary variable that was part of a discrete constraint was fixed above?
There was a problem hiding this comment.
It ends up being the same complexity for more complicated code. The only case that would help is if a constraint was mis-marked as being discrete and we would now fix that marking. The markers are in general treated as hints so I think that case is fine.
There was a problem hiding this comment.
Summary from offline conversation, @randomir correctly pointed out that it should be
Suggested change
| new_constraint.mark_discrete(old_constraint_ptr->marked_discrete() && | |
| old_constraint_ptr->is_onehot()); | |
| new_constraint.mark_discrete(old_constraint_ptr->marked_discrete() && | |
| new_constraint.is_onehot()); |
randomir
approved these changes
Apr 17, 2023
arcondello
force-pushed
the
fix-variables-copy
branch
from
fdf924d
to
846611f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to generate a new model when fixing variables rather than acting on the CQM in-place. This is almost always more performant. For instance, see the times for a 1000 variable and 1000 constraint CQM with different numbers of variables fixed.
Closes #1319