This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Feature proposal for job-shop-scheduling #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3ller
reviewed
Jul 3, 2019
m3ller
suggested changes
Jul 4, 2019
m3ller
reviewed
Jul 8, 2019
m3ller
reviewed
Jul 8, 2019
m3ller
approved these changes
Jul 25, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have two features that I think would improve the usability and performance of the job-shop-scheduling demo.
First, for jobs larger than those in the demo/testing files get_bqm may fail on the dwavebinarycsp.stitch if the default max_graph_size is too small. My first commit allows parameters to be passed through to dwavebinarycsp.stitch.
Second, the current variable pruning does not take advantage of knowledge of all tasks (I believe the TODO refers to this). Variables of a task are pruned only on their position within a job, and their duration. Pruning can be improved considering the duration of predecessor and successor tasks. The changes for this are in the second commit.