Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global wish #33

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Global wish #33

wants to merge 2 commits into from

Conversation

teehee567
Copy link
Contributor

@teehee567 teehee567 commented Apr 3, 2024

global wish counter
based on unique gachaid and date
every day will add to daily pulls table

  • total wishes per day
  • user pulled on banner count

@teehee567 teehee567 requested a review from a team as a code owner April 3, 2024 02:35
@teehee567
Copy link
Contributor Author

i forgot to click pull so the shit got duplicated

@maalni
Copy link
Member

maalni commented Apr 3, 2024

Is this pr complete?

@teehee567
Copy link
Contributor Author

Is this pr complete?

nope

@maalni maalni marked this pull request as draft April 4, 2024 09:55
@teehee567
Copy link
Contributor Author

Closes #24

@maalni maalni linked an issue Apr 9, 2024 that may be closed by this pull request
@teehee567 teehee567 closed this May 5, 2024
@teehee567 teehee567 deleted the global_wish branch May 5, 2024 14:12
@teehee567 teehee567 restored the global_wish branch May 5, 2024 14:12
@teehee567 teehee567 deleted the global_wish branch May 5, 2024 14:13
@teehee567 teehee567 restored the global_wish branch May 5, 2024 14:14
@teehee567
Copy link
Contributor Author

restart

@teehee567
Copy link
Contributor Author

huh

@teehee567 teehee567 reopened this May 6, 2024
@@ -0,0 +1,6 @@
import { PrismaClient } from '@prisma/client'

export const prisma = new PrismaClient();
Copy link
Member

@maalni maalni May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will return a new instance every time its accessed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a single instance you need to wrap the client in a singleton https://en.wikipedia.org/wiki/Singleton_pattern

Copy link

sonarcloud bot commented Jul 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global wish statistics
2 participants