Fix incorrect filter behavior when combining multiple regexp #5053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4590
With multiple regexp filters, if an earlier filter matches only part of a path, any other filters were ignored.
Steps to reproduce
/a/
,/b/
and/a/c/
(names irrelevant)[/(a|b)/]
and[/a/c/]
and exclude.*
FilterTests.CombineRegexp
Current behavior
(/(a|b)/)|(/a/c/)
, which will match the part/a/
of/a/c/
. This is detected as a mismatch, so the path is excluded.New behavior
^((^(/(a|b)/)$)|(^(/a/c/)$))$
(not ideal in terms of delimiters, but works). This forces the match to the full path/a/c/
. The path is included as it should be.