-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regexp Include filter ignored but identical filter without regexp [] works #4590
Comments
The problem is that the regexp expressions are combined into |
Closes duplicati#4590 With multiple regexp filters, if an earlier filter matches only part of a path, any other filters were ignored.
Closes duplicati#4590 With multiple regexp filters, if an earlier filter matches only part of a path, any other filters were ignored.
Environment info
Description
I found a special scenario where Duplicati fails to include by path when filter used as regexp:
--include="[/mnt/user/share/]"
and when identical used as non-regexp, it works:
--include="[/mnt/user/share/]"
I've included a zip with the data dir and two commands, one which fails, and one which works
It only seems to happen if a following exclude will exclude parent-folders of the source dir. However the first two filters ensures the include from the top of the source, and also there shouldn't be a difference between regexp and non-regexp as long as they both match. In other words I got configuration to work as I wanted by avoiding exclude [/.*/] and instead exclude from my source dir
[/mnt/user/share/.*/]
. I'm not certain whether this is coincidental or not.Error-Command
The second and third filter above should both have included user/share folder
Output from error variant, should have included
/mnt/user/media/TestDuplicati/user/share/
Success full Command
Note the only difference is removal of [] brackets around 3. filter. Same result if we remove the second (regexp) filter below..
Output from success variant, which correctly includes
/mnt/user/media/TestDuplicati/user/share/
PS: It would be nice if test-filters had an option to not list all included files but just number of files in each dir (or something).
TestDuplicati-support.zip
system-info.txt
The text was updated successfully, but these errors were encountered: