Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Config objects immutable #250

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make Config objects immutable #250

wants to merge 3 commits into from

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Apr 27, 2021 •
edited by duckinator
Loading

This is a stepping stone towards making Config be a dataclass,
so the new dependency on frozendict might not stay long.

Piggy-backs on #249 (Config.resolved: Major bugfix(es)) so please merge that first

@nbraud
config: Make Config objects immutable
a05f9be 
This cleans up a fair bit of the logic in here, and safeguards us against
potential bugs.  It is however a technically-breaking change.
@nbraud
Copy link
Collaborator Author

nbraud commented Apr 27, 2021

Why is frozendict not a thing in the standard library anyhow?

@duckinator
Copy link
Owner

duckinator commented Apr 28, 2021 •
edited
Loading

@nbraud I merged #249 - not sure what to do with this one since there's so much overlap between the two.

@duckinator
Copy link
Owner

Updated this to be based on the current codebase and use latest frozendict. There's some problems with Config.copy() not having kwargs even though your code expects it to accept them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @duckinator