impl<T> Write for UniquePtr<T> where ... Pin<&a mut T> : Write.
#1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you PTAL? FWIW the earlier explanation and discussion from #1368 also apply here - e.g. the earlier PR says why there are no tests, and why it's okay not to worry for now about forwarding other traits. |
This commit implements forwarding of `Write` trait implementation from `UniquePtr<T>` to the pointee type. This is quite similar to how `Box<T>` also forwards - see https://doc.rust-lang.org/std/boxed/struct.Box.html#impl-Write-for-Box%3CW%3E This commit has quite similar, orphan-rule-related motivation as the earlier dtolnay#1368 which covered the `Read` trait. For a more specific motivating example, please see http://review.skia.org/skia/+/923337/3/experimental/rust_png/ffi/FFI.rs#254
anforowicz
force-pushed
the
write-trait-blanket-impl-for-unique-ptr
branch
from
83299d1
to
a2fe88c
Compare
|
Ooops... I've just realized that one of the links in the commit description doesn't work. Let me fix that in a force push... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements forwarding of
Writetrait implementation fromUniquePtr<T>to the pointee type. This is quite similar to howBox<T>also forwards - seehttps://doc.rust-lang.org/std/boxed/struct.Box.html#impl-Write-for-Box%3CW%3E
This commit has quite similar, orphan-rule-related motivation as the earlier #1368 which covered the
Readtrait. For a more specific motivating example, please see http://review.skia.org/c/skia/+/923337/3/experimental/rust_png/ffi/FFI.rs#254