Add no_exceptions feature flag
#1343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rib
added a commit
to EmbarkStudios/cxx
that referenced
this pull request
Apr 24, 2024
We need to use a fork of the cxx crate until something like dtolnay#1343 can hopefully be merged upstream but we also don't want to require Windows developers to have to enable support for symlinks, so we'll instead copy the syntax directory, similar to what would effectively happen when the cxx crate is published to crates.io
|
Note now that the This might become more important, either need a way to read from the env vars to setup the define or maybe a feature like this is the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin.
Closes: #1317