Add custom deleter support to UniquePtr #1305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possibility to use shared trivial types as deleters for objects managed by std::unique_ptr / UniquePtr.
darkwisebear
force-pushed
the
uniqueptr_deleter
branch
from
ed5d2e5
to
8336f62
Compare
GCC does not accept an extern "C" storage class specifier along with definition of the global variable. Split declaration and definition to overcome this.
Apparently MacOS's unique_ptr implementation puts the deleter as the 2nd member. Reflect this in the unique_ptr definition.
* Add unnamed lifetimes to drop implementation for UniquePtrTarget * Update expected stderr to include the deleter type parameter.
|
@dtolnay Does this PR have chances to be merged as-is or is there still something I need to do with it in order to get it merged? |
|
Well, now this guy has a merge conflict. It shouldn't be a big deal to fix it but is it really worth it? Was it laying around for such a long time because the change is bad? If yes, please tell me. On a more general side, is it worth that I also add allocator support to vector and shared_ptr? Probably not because I feel that for some reason there is no chance of such changes to ever getting merged. If that is due to lack of time I'd be glad to help here. There's a lot of pending PRs that would be embraced by the community and maybe a lot of stuff that people would be willing to contribute I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to use shared trivial types as deleters for objects managed by std::unique_ptr / UniquePtr.