Add UniquePtr::to_shared and SharedPtr::from_unmanaged #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed that error and added an additional test to cover the situation, but it needs approval to run again. Just pinging just in case you don't get commit notifications. |
russelltg
force-pushed
the
uniq2shared
branch
from
0a7d5cd
to
924bd9c
Compare
|
Freshly rebased onto master :) |
russelltg
force-pushed
the
uniq2shared
branch
2 times, most recently
from
781580e
to
8d1705b
Compare
russelltg
force-pushed
the
uniq2shared
branch
from
8d1705b
to
f7dc455
Compare
|
Hmm I think it would be reasonable also to implement |
russelltg
force-pushed
the
uniq2shared
branch
from
f03d505
to
2202524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to create SharedPtr's from C++ pointers created with
new(or viaunique_ptrs).I'm a new contributor here, let me know if I did this in a reasonable way, and I'm happy to put some effort in if this is something that's interesting.