Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar #62

Open
dtolnay opened this issue Apr 20, 2019 · 0 comments
Open

Show progress bar #62

dtolnay opened this issue Apr 20, 2019 · 0 comments

Comments

@dtolnay
Copy link
Owner

dtolnay commented Apr 20, 2019

Currently the Cargo subprocess spawned by cargo-expand does not display Cargo's usual progress bar. I believe this is because we pipe the child's stderr to perform filtering here:

let mut child = cmd.stderr(Stdio::piped()).spawn()?;

and that means Cargo does not get a winsize from this ioctl:

https://github.com/rust-lang/cargo/blob/6be12653dcefb46ee7b605f063ee75b5e6cba513/src/cargo/core/shell.rs#L377

I tried a naive fix in #61 but it didn't work, the second ioctl fails with:

Inappropriate ioctl for device (os error 25)

Will need to figure out what's the correct way to provide a winsize to the child process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant