[WIP] Invoke commands to combine

[IvanShamatov]

I'm working on idea of invoking commands from other commands to combine them together.
Say you have views, model, controller generators and you want to make a scaffold command

module Generate
  class Scaffold < Dry::CLI::Command
    argument :model_name

    def call(model_name:)
      invoke(%w[g model], model_name)
      invoke(%w[g controller], model_name)
    end
  end

  class Model < Dry::CLI::Command
    argument :model_name

    def call(model_name:)
      invoke(%[g migration], model_name)
      some_other_model_staff
    end
  end

  class Controller < Dry::CLI::Command
    argument :model_name

    def call(model_name:)
      add_routes
      add_controller
    end

    def add_controller(model_name)
      ACTIONS.each { |action|  invoke(%[g views], model_name, action) }
      some_other_controller_staff
    end
  end
end

WDYT ?

[solnic]

This is a useful feature. I already needed it in a couple of places.

[jodosha]

@IvanShamatov This is useful, indeed. What I suggest if it's possible to use message passing, instead of system calls to execute other commands it would be preferrable. But if that is the cost of messing with the command name registry then system calls are fine.

Please invest a little bit more time in thinking what happens if the invoked command crashes.

[solnic]

I think this should just use command objects - is it not possible/feasible now? I do that easily in tests so...

[IvanShamatov]

@solnic I do not pass registry into commands, but to be able to invoke commands from commands expect registry be injected into command object. Actually I'm thinking about that way of implementation and will definitely try it in the nearest time.

[dry-bot]

Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

See the complete overview on Codacy

[dry-bot]

Issue found: Prefer single-quoted strings when you don't need string interpolation or special symbols.

[solnic]

@IvanShamatov as the comment states: to update dependencies you need to edit project.yml 😄

[dry-bot]

Issue found: Add an empty line after magic comments.

[adrianthedev]

+1 from me too.

Thanks for working on this!