Update to use new Drupal Finder (Composer Runtime) API #650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal Finder has been revamped to use the Composer Runtime API, which makes it much simpler in how it operates. This PR updates the composer script handler to use this new Drupal Finder API. It also adds an additional panic exit in case the root cannot be found.
See also https://github.com/webflo/drupal-finder/releases/tag/1.3.0.
Edit: this requires some kind of additional work for new installations, given that the
Path::makeRelative
call seems to be failing on new installations, supposedly due togetComposerRoot
returningnull
on fresh installations. I'm not sure yet on the fix that is required here (or maybe upstream?). A repeatedcomposer install
run seems to fix the issues.