Remove logback-access
from the core framework
#8073
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment we could/should think of dropping support for
logback-access
. Logback doesn't support Jetty 12 yet and the related issue hasn't received comments for about two months.This PR is meant to show the consequences of removing the
logback-access
dependency from the core framework modules.The
LogbackAccessRequestLogFactory
will be removed andLogbackClassicRequestLogFactory
will be the new default.The JSON logging related
access-json
layout will be removed too.I've further evaluated what it would look like supporting
logback-access
without the hard dependency indropwizard-request-logging
anddropwizard-json-logging
. We currently have a workaround to get theLogbackAccessRequestLog
working again, so we could lower the migration costs with supporting the workaround for some time (then preferably in a separate repo which will be deprecated directly). A necessary precondition for that is introducing theServerCustomizer
interface to allow customizations of the Jetty handler chain.