Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for auto-creation of conda environments #170

Closed
wants to merge 1 commit into from
Closed

Added support for auto-creation of conda environments #170

wants to merge 1 commit into from

Conversation

jraviotta
Copy link
Contributor

This is one possible resolution for #168 .

This PR updates the Makefile requirements target with logic for selecting package and environment managers. If conda is detected, a conda environment is created and then updated with a new environment.yml file. If conda is not detected, requirements.txt is installed with pip and then an environment is created with virtualenv as before.

The conda condition successfully creates the environment and the local package src is available in the jupyter kernel in jupyter lab. I can run the notebook cell described in #168 without an error.

I have not tested the virtualenv condition as I am unfamiliar with it's normal behavior.

@pjbull
Copy link
Member

pjbull commented May 24, 2019

Thanks for the interest in this feature @jraviotta!

We're not going to merge this as-is, since we're moving to allowing the user to pick an option rather than bundling everything together. (see #162) If you want to test the changes on that branch with your conda flow, it would be great to hear the results.

@pjbull pjbull closed this May 24, 2019
@jraviotta jraviotta deleted the environment branch May 30, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants