-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permission): support permission #1931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Gggpound
force-pushed
the
feat/permission-0415
branch
5 times, most recently
from
April 26, 2024 03:10
725ee2e
to
fccaed3
Compare
Gggpound
force-pushed
the
feat/permission-0415
branch
6 times, most recently
from
May 6, 2024 13:44
7d2f8eb
to
babc5c2
Compare
Gggpound
force-pushed
the
feat/permission-0415
branch
4 times, most recently
from
May 13, 2024 11:51
8f6df5c
to
24fa756
Compare
ybzky
force-pushed
the
feat/permission-0415
branch
2 times, most recently
from
May 17, 2024 11:59
1afae29
to
18c668c
Compare
Gggpound
requested review from
Jocs,
ybzky,
yuhongz,
weird94 and
Dushusir
as code owners
May 18, 2024 02:27
wzhudev
reviewed
May 25, 2024
packages/sheets/src/services/permission/worksheet-permission/protect-background-img.ts
Outdated
Show resolved
Hide resolved
wzhudev
reviewed
May 25, 2024
packages/sheet-permission-ui/src/views/error-msg-dialog/index.module.less
Show resolved
Hide resolved
wzhudev
reviewed
May 25, 2024
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts
Outdated
Show resolved
Hide resolved
wzhudev
reviewed
May 25, 2024
wzhudev
reviewed
May 25, 2024
packages/sheets-selection-protection/src/selection-protection-plugin.ts
Outdated
Show resolved
Hide resolved
...eets-selection-protection/src/service/selection-protection/selection-protection.ref-range.ts
Outdated
Show resolved
Hide resolved
wzhudev
reviewed
May 25, 2024
packages/sheets-selection-protection/src/model/selection-protection-render.model.ts
Outdated
Show resolved
Hide resolved
wzhudev
requested changes
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few headsup:
- Please follow our naming convention.
- Please avoid exposing methods or properties that are not called by outside code
Gggpound
force-pushed
the
feat/permission-0415
branch
2 times, most recently
from
May 27, 2024 02:54
825c215
to
3551c38
Compare
zhaolixin7
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
May 28, 2024
Gggpound
force-pushed
the
feat/permission-0415
branch
from
May 28, 2024 03:44
8c826ba
to
1746849
Compare
wzhudev
reviewed
May 28, 2024
wzhudev
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some code readability issue need to be addressed.
packages/debugger/src/commands/operations/set.editable.operation.ts
Outdated
Show resolved
Hide resolved
packages/sheet-permission-ui/src/command/range-protection.command.ts
Outdated
Show resolved
Hide resolved
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts
Outdated
Show resolved
Hide resolved
wzhudev
reviewed
May 28, 2024
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts
Outdated
Show resolved
Hide resolved
wzhudev
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #540