Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip the sync peer that does not belong to the scheduler cluster #3731

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes changes to the manager/job/sync_peers.go file to improve the synchronization of peers, specifically addressing compatibility with the Rust client. The most important changes include updating the SyncPeers interface documentation and adding a condition to handle scheduler clusters in the mergePeers function.

Documentation update:

  • manager/job/sync_peers.go: Updated the SyncPeers interface comment to specify that it is only supported in the Rust client.

Functionality improvement:

  • manager/job/sync_peers.go: Added a condition in the mergePeers function to skip sync peers that do not belong to the scheduler cluster, as the Golang client lacks the SchedulerClusterID field.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 27, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 27, 2024
@gaius-qi gaius-qi self-assigned this Dec 27, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner December 27, 2024 08:09
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit f945894 into main Dec 27, 2024
22 of 23 checks passed
@gaius-qi gaius-qi deleted the feature/sync branch December 27, 2024 08:10
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (cc235df) to head (0e5cc25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/job/sync_peers.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3731   +/-   ##
=======================================
  Coverage   35.19%   35.20%           
=======================================
  Files         335      335           
  Lines       37803    37807    +4     
=======================================
+ Hits        13306    13309    +3     
- Misses      23670    23671    +1     
  Partials      827      827           
Flag Coverage Δ
unittests 35.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/job/sync_peers.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants